PR #2450 Context manager fixes

Context manager fixes #2450

muellerzr merged 4 commits into huggingface:main from akx:context-mgr-fixes

akx force pushed from 6a3f3231 to 8ab9a230 2 years ago

akx force pushed from 8ab9a230 to 57f9dcb7 2 years ago

BenjaminBossan commented on 2024-02-15

akx force pushed from 57f9dcb7 to c1181691 2 years ago

akx requested a review from

BenjaminBossan 2 years ago

BenjaminBossan approved these changes on 2024-02-16

BenjaminBossan requested a review from

muellerzr 2 years ago

akx force pushed from c1181691 to d0efbf44 2 years ago

Ban use of `os.*env`

968b1158

Fix `clear_environment` to actually clear environment variables

4b56d80d

Have environment context managers restore state even if the block raises

4adcc151

Add tests for environment CMs

ca4b3f7c

akx force pushed from d0efbf44 to ca4b3f7c 2 years ago

akx requested a review from

BenjaminBossan 2 years ago

muellerzr approved these changes on 2024-02-26

BenjaminBossan approved these changes on 2024-02-26

muellerzr merged 34fdddd7 into main 2 years ago

Reviewers

BenjaminBossan

muellerzr

Assignees

No one assigned

Labels

None yet

Milestone

No milestone