PR #2998 Make env variables optional for FSDP

Make env variables optional for FSDP #2998

muellerzr merged 10 commits into main from make-dataclass-optional

Bookmark

d5fd90f3

Tests pass!

b95ad443

Fix imports

c971a7fc

muellerzr requested a review from

matthewdouglas 1 year ago

muellerzr requested a review from

SunMarc 1 year ago

Try with raw dict

78411d07

Make diff easier

bb21bdcf

SunMarc approved these changes on 2024-08-08

matthewdouglas approved these changes on 2024-08-08

BenjaminBossan commented on 2024-08-08

Add defaults to all relevent areas

f9fd938a

Rest of refactor

f83bc904

Fix all of benjamin's nits

f6de455f

BenjaminBossan approved these changes on 2024-08-12

Adjust logic based on Benjamin's feedback

f4ce667d

Adjust for new logic

f8c496c0

muellerzr merged 3bde6156 into main 1 year ago

muellerzr deleted the make-dataclass-optional branch 1 year ago

Reviewers

BenjaminBossan

matthewdouglas

SunMarc

Assignees

No one assigned

Labels

None yet

Milestone

No milestone