[SDXL] Improve docs #4196
patrickvonplaten
merged
7 commits into
main
from
improve_sd_xl_docs_again
Improve docs
73548fcd
stevhliu
commented
on 2023-07-21
src/diffusers/pipelines/stable_diffusion_xl/pipeline_stable_diffusion_xl.py
| 670 | 670 | [Common Diffusion Noise Schedules and Sample Steps are Flawed](https://arxiv.org/pdf/2305.08891.pdf). | |
| 671 | 671 | Guidance rescale factor should fix overexposure when using zero terminal SNR. | |
| 672 | 672 | original_size (`Tuple[int]`, *optional*, defaults to (1024, 1024)): | |
| 673 | TODO | ||
| 673 | Part of SDXL's micro-conditioning as explained in section 2.2 of [https://huggingface.co/papers/2307.01952](https://huggingface.co/papers/2307.01952). | ||
| 674 | If `original_size` is not the same as `target_size` the image will appear to be down- or upsampled. `original_size` defaults to `(width, height)` if not specified. |
stevhliu2 years agoWhat do you think about shortening it to like the below so it's a bit shorter/easier to read (big ➕ for linking to hf.co/papers!), and I think it'd be clearer to lead with what the parameter does?
Suggested change
| Part of SDXL's micro-conditioning as explained in section 2.2 of [https://huggingface.co/papers/2307.01952](https://huggingface.co/papers/2307.01952). | |
| If `original_size` is not the same as `target_size` the image will appear to be down- or upsampled. `original_size` defaults to `(width, height)` if not specified. | |
| If `original_size` is not the same as `target_size` the image will appear to be down- or upsampled. `original_size` defaults to `(width, height)` if not specified (see [SDXL micro-conditioning](https://huggingface.co/papers/2307.01952) for more details). |
patrickvonplaten2 years agoSwapped the two sentences - would like to keep the "section 2.2" part so that people don't have to search the whole paper. Let me know what you think :-)
stevhliu2 years agoNice, that works for me! 👍
Correct docs
a9463924
Add better example inpaint
d726b39d
make style
0f1b2d34
Merge branch 'main' into improve_sd_xl_docs_again
c3b41122
HuggingFaceDocBuilderDev2 years ago (edited 2 years ago)
The documentation is not available anymore as the PR was closed or merged.
stevhliu
approved these changes
on 2023-07-24
stevhliu2 years ago
Awesome! 👍
Conversation is marked as resolved
Conversation is marked as resolved
Apply suggestions from code review
b950e073
fix
1d79750d
Login to write a write a comment.
What does this PR do?
Adds missing docs for micro conditioning and corrects inpainting example for SD-XL
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.