diffusers
Fix CPU Offloading Usage
#8230
Merged

Fix CPU Offloading Usage #8230

stevhliu merged 4 commits into huggingface:main from tolgacangoz:fix-typos
tolgacangoz
tolgacangoz1 year ago (edited 1 year ago)

Fixes CPU offloading usage.
@stevhliu

tolgacangoz tolgacangoz changed the title [`Docs`] Fix typos Fix CPU Offloading Usage & Typos 1 year ago
stevhliu
stevhliu approved these changes on 2024-05-22
stevhliu1 year ago

LGTM! Pinging @sayakpaul, @yiyixuxu @DN6 for a quick peek since the PR also touches the test scripts :)

sayakpaul
sayakpaul commented on 2024-05-22
sayakpaul1 year ago

Just a single comment but rest looks good to me.

examples/kandinsky2_2/text_to_image/train_text_to_image_decoder.py
896896 images = []
897897 if args.validation_prompts is not None:
898898 logger.info("Running inference for collecting generated images...")
899
pipeline = pipeline.to(accelerator.device)
sayakpaul1 year ago

Why is this going away?

yiyixuxu1 year ago

it called enable_model_cpu_offload() right after

yiyixuxu
yiyixuxu approved these changes on 2024-05-23
yiyixuxu1 year ago

thanks!

tolgacangoz tolgacangoz requested a review from sayakpaul sayakpaul 1 year ago
tolgacangoz tolgacangoz requested a review from stevhliu stevhliu 1 year ago
tolgacangoz Fix typos
d584157c
tolgacangoz Fix `pipe.enable_model_cpu_offload()` usage
1b72d7eb
tolgacangoz Fix cpu offloading
37320977
tolgacangoz Update numbers
f83e5770
stevhliu stevhliu force pushed from f23bbce6 to f83e5770 1 year ago
HuggingFaceDocBuilderDev
HuggingFaceDocBuilderDev1 year ago

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

stevhliu
stevhliu approved these changes on 2024-05-24
stevhliu stevhliu merged 0ab63ff6 into main 1 year ago
tolgacangoz
tolgacangoz1 year ago

Thanks for merging!

tolgacangoz tolgacangoz deleted the fix-typos branch 1 year ago
tolgacangoz tolgacangoz changed the title Fix CPU Offloading Usage & Typos Fix CPU Offloading Usage 234 days ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone