peft
Warn if using tied target module with `tie_word_embeddings`
#2025

Merged

Warn if using tied target module with `tie_word_embeddings` #2025

BenjaminBossan merged 29 commits into huggingface:main from ltoniazzi:bug/warn-if-tied-embedding

ltoniazzi commented on 2024-08-20

ltoniazzi marked this pull request as ready for review 1 year ago

ltoniazzi commented on 2024-08-20

BenjaminBossan requested changes on 2024-08-21

ltoniazzi marked this pull request as draft 1 year ago

ltoniazzi force pushed from c2361292 to 44a02de8 1 year ago

ltoniazzi marked this pull request as ready for review 1 year ago

ltoniazzi changed the title ~~Add warning if using output target module whith tied embeddings~~ Add warning if using output target module with tied embeddings 1 year ago

ltoniazzi changed the title ~~Add warning if using output target module with tied embeddings~~ Warn if using output target module with tied embeddings 1 year ago

BenjaminBossan requested changes on 2024-08-22

BenjaminBossan requested changes on 2024-08-23

ltoniazzi force pushed from 516fc3c1 to 3a51e672 1 year ago

ltoniazzi force pushed from cd3e8303 to cf4bf3ec 1 year ago

ltoniazzi marked this pull request as draft 1 year ago

ltoniazzi marked this pull request as ready for review 1 year ago

ltoniazzi commented on 2024-08-25

BenjaminBossan requested changes on 2024-08-26

Add warning if using output target module whith tied embeddings

b610bbc9

Add embed

dbd1eab0

Use EMBEDDING_LAYER_NAMES

b0d3e616

Update src/peft/mapping.py

c8d6236a

Remove line

4e24774b

Update src/peft/mapping.py

39c9c4b2

Move warn in BaseTuner

388b3f48

Rename BaseTuner in mapping

b5fa3ced

Modify warning message

f36f3af3

Style

acde170e

Precommit

06f0d00d

Docstr for get_model_config and separate warnings

d9b2b535

Reword

fe5c86f6

Typo

5ba0e9f4

Put warn in base class - force dummy config

775a325a

Fix bug from rebase

fc0541e0

Add get model config tests

a1e5c170

Add warning test for merging/loading

0861e1ef

Refactor warn test

82cab474

Refactor warn test

667c0338

Refactor warn test

5c6c4568

Update tests/test_tuners_utils.py

12c73b59

Update merge warning message

7f290ea6

Decouple tests

7926888d

ltoniazzi force pushed from a2f7354b to 7926888d 1 year ago

ltoniazzi marked this pull request as draft 1 year ago

Add instructions to save an untied model

6d360a9a

Add instructions to save an untied model

964fdae8

Add comment on different format

89928caa

ltoniazzi marked this pull request as ready for review 1 year ago

Run make style

809f689e

ltoniazzi changed the title ~~Warn if using output target module with tied embeddings~~ Warn if using tied target module with `tie_word_embeddings` 1 year ago

BenjaminBossan requested changes on 2024-08-28

Address comments

37a56ebf

BenjaminBossan approved these changes on 2024-08-29

BenjaminBossan merged 679bcd87 into main 1 year ago

ltoniazzi deleted the bug/warn-if-tied-embedding branch 1 year ago

Reviewers

BenjaminBossan

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

peft Warn if using tied target module with `tie_word_embeddings` #2025 Merged

Warn if using tied target module with `tie_word_embeddings` #2025

peft
Warn if using tied target module with `tie_word_embeddings`
#2025

Merged