peft
Add Conv1D support to CoRDA for GPT-2 compatibility #2991
#2992

Merged

Add Conv1D support to CoRDA for GPT-2 compatibility #2991 #2992

BenjaminBossan merged 10 commits into huggingface:main from sambhavnoobcoder:corda-conv1d-support

Add Conv1D support to CoRDA for GPT-2 compatibility

37934858

Handle Conv1D weight transpose in collect_eigens_for_layer

29fa1ff4

BenjaminBossan requested changes on 2026-01-13

Fix Conv1D dimension checks in crop_corda_eigens

5daefdaa

Fix Conv1D dimension handling in corda_init

b3a41932

Add unit test for CoRDA Conv1D support with GPT-2

2b988298

BenjaminBossan requested changes on 2026-01-13

Use transpose function for Conv1D delta normalization

a022b1a5

Use tiny-random-gpt2 and random input for Conv1D test

17f85173

Make imports global and add explanatory comments

bc352015

issue fix

3506424d

sambhavnoobcoder requested a review from

BenjaminBossan 78 days ago

BenjaminBossan commented on 2026-01-13

Use self.fan_in_fan_out instead of isinstance check for transpose

6b4427b7

BenjaminBossan approved these changes on 2026-01-13

BenjaminBossan merged 389f5883 into main 78 days ago

Reviewers

BenjaminBossan

Assignees

No one assigned

Labels

None yet

Milestone

No milestone