transformers
[Design proposal] Fix EncoderDecoderModel classes to be more like BART and T5
#14139

Merged

[Design proposal] Fix EncoderDecoderModel classes to be more like BART and T5 #14139

NielsRogge merged 10 commits into huggingface:master from NielsRogge:align_encoder_decoder_models

First draft

68809578

NielsRogge requested a review from

sgugger 4 years ago

NielsRogge requested a review from

LysandreJik 4 years ago

sgugger approved these changes on 2021-10-25

Make tuple output more readable

599ea2e3

Replace assertions by value errors

7f7ec3f9

Make it possible to predict_with_generate for vision and speech models

8ce50c5d

Adapt Seq2SeqTrainer to work with VisionEncoderDecoder/SpeechEncoderD…

9937637c

LysandreJik approved these changes on 2021-10-26

Add deprecation warning

2c21151f

Add copied from statements to vision and speech encoder decoders

554b47fb

LysandreJik requested a review from

patil-suraj 4 years ago

patil-suraj commented on 2021-10-27

patil-suraj approved these changes on 2021-10-27

NielsRogge marked this pull request as ready for review 4 years ago

Fix failing test

dfbbceb8

LysandreJik approved these changes on 2021-10-27

patrickvonplaten commented on 2021-10-27

patrickvonplaten approved these changes on 2021-10-27

Apply @patrickvonplaten's suggestion

263f54de

Use reshape instead of view for consistency

8aa8ce66

NielsRogge merged ac12a5ae into master 4 years ago

Reviewers

LysandreJik

patrickvonplaten

patil-suraj

sgugger

ydshieh

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

transformers [Design proposal] Fix EncoderDecoderModel classes to be more like BART and T5 #14139 Merged

[Design proposal] Fix EncoderDecoderModel classes to be more like BART and T5 #14139

transformers
[Design proposal] Fix EncoderDecoderModel classes to be more like BART and T5
#14139

Merged