PR #17426 TF: GPT-2 generation supports left-padding

TF: GPT-2 generation supports left-padding #17426

gante merged 8 commits into huggingface:main from gante:xla_gpt2

gante requested a review from

Rocketknight1 4 years ago

gante requested a review from

patrickvonplaten 4 years ago

gante commented on 2022-05-25

Rocketknight1 commented on 2022-05-26

Rocketknight1 approved these changes on 2022-05-26

gante commented on 2022-05-26

patrickvonplaten commented on 2022-05-26

tmp commit

e1bf8660

TF GPT-2 now properly works with left padding

819d4a19

only pre-write pad token when it is non zero and non None

744c4857

Fix tf generate attention mask where eos token == pad token

2bf64a14

fix the case in the previous commit where left padding is also present

05b8192c

throw a warning instead

73dad3ba

make fixup

a5ee75c6

attention mask has to stay as arg

ed266959

gante force pushed to ed266959 4 years ago

patrickvonplaten approved these changes on 2022-05-30

patrickvonplaten requested a review from

sgugger 4 years ago

gante merged 975dd2bb into main 4 years ago

gante deleted the xla_gpt2 branch 4 years ago

ydshieh commented on 2022-06-05

Reviewers

Rocketknight1

patrickvonplaten

ydshieh

sgugger

Assignees

No one assigned

Labels

None yet

Milestone

No milestone