PR #25702 remove SharedDDP as it is deprecated

remove SharedDDP as it is deprecated #25702

LysandreJik merged 8 commits into huggingface:main from ji-huazhong:drop_sharde_ddp

ji-huazhong marked this pull request as draft 2 years ago

ji-huazhong commented on 2023-08-24

ji-huazhong changed the title ~~remove SharedDDP as it is drepracated~~ remove SharedDDP as it is deprecated 2 years ago

ji-huazhong commented on 2023-08-24

ji-huazhong marked this pull request as ready for review 2 years ago

ji-huazhong force pushed 2 years ago

ji-huazhong force pushed 2 years ago

pacman100 commented on 2023-08-28

ji-huazhong force pushed 2 years ago

muellerzr commented on 2023-09-01

ji-huazhong closed this 2 years ago

ji-huazhong reopened this 2 years ago

muellerzr approved these changes on 2023-09-01

ji-huazhong requested a review from

pacman100 2 years ago

ji-huazhong force pushed 2 years ago

pacman100 commented on 2023-09-07

ji-huazhong force pushed 2 years ago

ji-huazhong requested a review from

pacman100 2 years ago

muellerzr approved these changes on 2023-09-07

amyeroberts commented on 2023-09-07

ji-huazhong force pushed 2 years ago

amyeroberts approved these changes on 2023-09-13

pacman100 approved these changes on 2023-09-14

ji-huazhong force pushed 2 years ago

remove SharedDDP as it was drepracated

2c9a538e

apply review suggestion

892e5549

make style

7f77ffc3

Oops,forgot to remove the compute_loss context manager in Seq2SeqTrai…

224f397c

remove the unnecessary conditional statement

a1a6d78a

keep the logic of IPEX

f7c87d80

clean code

1af9b590

mix precision setup & make fixup

140bd1d5

LysandreJik force pushed to 140bd1d5 2 years ago

LysandreJik approved these changes on 2023-10-06

LysandreJik merged 27597fea into main 2 years ago

ji-huazhong deleted the drop_sharde_ddp branch 2 years ago

Reviewers

LysandreJik

pacman100

amyeroberts

muellerzr

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

transformers remove SharedDDP as it is deprecated #25702 Merged

remove SharedDDP as it is deprecated #25702

transformers
remove SharedDDP as it is deprecated
#25702

Merged