transformers
Fix `_merge_input_ids_with_image_features` for llava model
#28333

Merged

Fix `_merge_input_ids_with_image_features` for llava model #28333

younesbelkada merged 9 commits into huggingface:main from VictorSanh:fix-llava-merge-inputs

fix `_merge_input_ids_with_image_features` for llava model

24ac001d

VictorSanh commented on 2024-01-03

ArthurZucker commented on 2024-01-04

Update src/transformers/models/llava/modeling_llava.py

28be7e19

adress comments

ab7dd6c7

style and tests

1422a80e

ooops

18f43d6c

ArthurZucker approved these changes on 2024-01-05

test the backward too

3dac7424

younesbelkada commented on 2024-01-08

VictorSanh commented on 2024-01-08

Apply suggestions from code review

25674f07

VictorSanh commented on 2024-01-08

Update tests/models/vipllava/test_modeling_vipllava.py

c16d58c2

style and quality

c3cab276

younesbelkada approved these changes on 2024-01-09

younesbelkada merged 0f2f0c63 into main 2 years ago

Reviewers

ArthurZucker

younesbelkada

Assignees

No one assigned

Labels

None yet

Milestone

No milestone