PR #29225 Fix `kwargs` handling in `generate_with_fallback`

Fix `kwargs` handling in `generate_with_fallback` #29225

ArthurZucker merged 6 commits into huggingface:main from cifkao:fix-generate-with-fallback-kwargs

Fix generate_with_fallback **kwargs

9a692bc6

Change pop to get

6b38f76e

Delete keys from kwargs to prevent overriding generation_config

2671894a

Revert to passing kwargs by reference, but make a (shallow) copy

c74edca5

ArthurZucker requested a review from

sanchit-gandhi 2 years ago

ArthurZucker requested a review from

ylacombe 2 years ago

ylacombe approved these changes on 2024-03-07

dict -> copy.copy

64e31632

ArthurZucker commented on 2024-03-30

cifkao requested a review from

ArthurZucker 2 years ago

sanchit-gandhi approved these changes on 2024-04-02

Add test_whisper_longform_multi_batch_beam

39d09a35

ArthurZucker approved these changes on 2024-04-03

ArthurZucker merged bcd42c4a into main 2 years ago

Reviewers

ArthurZucker

sanchit-gandhi

ylacombe

Assignees

No one assigned

Labels

None yet

Milestone

No milestone