PR #29721 Fix llava half precision and autocast issues

Fix llava half precision and autocast issues #29721

amyeroberts merged 9 commits into huggingface:main from frasermince:frasermince/half-precision-llava-fix

amyeroberts commented on 2024-03-19

frasermince force pushed from 2ea18247 2 years ago

frasermince force pushed 2 years ago

frasermince marked this pull request as draft 2 years ago

frasermince changed the title ~~Match original llava implentation by casting to pixel_values dtype.~~ Fix llava half precision and autocast issues 2 years ago

frasermince commented on 2024-04-09

frasermince requested a review from

amyeroberts 2 years ago

frasermince marked this pull request as ready for review 2 years ago

frasermince commented on 2024-04-09

amyeroberts commented on 2024-04-10

frasermince force pushed 2 years ago

muellerzr approved these changes on 2024-04-24

frasermince force pushed 2 years ago

muellerzr approved these changes on 2024-04-25

amyeroberts commented on 2024-04-25

amyeroberts approved these changes on 2024-04-25

amyeroberts added run-slow

frasermince force pushed 2 years ago

Ensure input_embeds and image_features are the same dtype in autocast

6d26a70e

Fix nans in half precision llava-next and fix autocasting behavior.

34e526fd

Fix styling issues.

a78ae59b

fix randn newline instantiation

3d58236a

fix broken slow llava test

f69af48d

Fix llava next init.

74fa019d

fix styling issues

30fb5ef9

[run-slow]llava,llava_next

750244ca

frasermince force pushed to 750244ca 2 years ago

fix styling issues

a399e4c1

amyeroberts merged 5090ea3f into main 2 years ago

Reviewers

amyeroberts

muellerzr

Assignees

No one assigned

Labels

run-slow

Milestone

No milestone

transformers Fix llava half precision and autocast issues #29721 Merged

Fix llava half precision and autocast issues #29721

transformers
Fix llava half precision and autocast issues
#29721

Merged