New option called `"best"` for `args.save_strategy`. #31817
ArthurZucker
merged
20 commits into
huggingface:main
from
feat/new-best-save-strategy
SunMarc
approved these changes
on 2024-10-18
seanswyi
commented
on 2024-10-19
ArthurZucker
commented
on 2024-10-24
SunMarc
approved these changes
on 2024-10-25
Add _determine_best_metric and new saving logic.
3ab35d99
Added SaveStrategy.
47ec1dd8
IntervalStrategy -> SaveStrategy
4e3c8bcc
IntervalStratgy -> SaveStrategy for save_strat.
11075402
Interval -> Save in docstring.
4528be61
Updated docstring for save_strategy.
9ec07f57
Added SaveStrategy and made according changes.
a494a54b
Changes from `make fixup`.
6831cd45
Removed redundant metrics argument.
45893201
Added new test_save_best_checkpoint test.
1ab8356d
Changed should_training_end saving logic.
b711c257
`args.metric_for_best_model` default to loss.
0956ad29
Undo metric_for_best_model update.
df5a0356
Remove checking metric_for_best_model.
bfbe2e0f
Added test cases for loss and no metric.
ff932cd0
Added error for metric and changed default best_metric.
f6e27251
Removed unused import.
aa44b305
`new_best_metric` -> `is_new_best_metric`
fbc990dc
Applied `is_new_best_metric` to all.
38216fe6
Merge branch 'main' into feat/new-best-save-strategy
ca831445
ArthurZucker
approved these changes
on 2024-10-28
shcheklein
commented
on 2024-12-19
Reviewers
Assignees
No one assigned
Labels
trainer
Milestone
No milestone
Login to write a write a comment.
Login via GitHub