transformers
Fix condition when GA loss bug fix is not performed
#35651

Merged

Fix condition when GA loss bug fix is not performed #35651

SunMarc merged 4 commits into huggingface:main from techkang:main

fix condition when GA loss bug fix is not performed

b95bf894

max loss diff is 2.29

91add0d0

techkang requested a review from

muellerzr 1 year ago

techkang requested a review from

SunMarc 1 year ago

techkang requested a review from

Rocketknight1 1 year ago

techkang requested a review from

ArthurZucker 1 year ago

hiyouga commented on 2025-01-13

muellerzr commented on 2025-01-13

fix typo

163cab68

add an extra validation that loss should not vary too much

f5040b25

muellerzr approved these changes on 2025-01-13

SunMarc approved these changes on 2025-01-16

SunMarc merged 2cbcc587 into main 1 year ago

ArthurZucker commented on 2025-01-16

Reviewers

SunMarc

muellerzr

ArthurZucker

hiyouga

yafshar

Rocketknight1

Assignees

No one assigned

Labels

None yet

Milestone

No milestone