PR #38106 More typing in src/transformers/training_args.py

More typing in src/transformers/training_args.py #38106

SunMarc merged 3 commits into huggingface:main from cyyever:training_argument_checking2

github-actions marked this pull request as draft 1 year ago

cyyever marked this pull request as ready for review 1 year ago

github-actions requested a review from

ArthurZucker 1 year ago

github-actions requested a review from

Rocketknight1 1 year ago

cyyever force pushed from 05763570 to a12806cd 1 year ago

cyyever force pushed from a12806cd to 8ad65e40 1 year ago

cyyever force pushed from 8ad65e40 to 1458cdd8 1 year ago

cyyever force pushed from 1458cdd8 to dae1be04 1 year ago

cyyever force pushed from dae1be04 to 8693449d 1 year ago

Rocketknight1 force pushed from 8693449d to 1d36ffc0 1 year ago

SunMarc dismissed these changes on 2025-05-19

SunMarc dismissed their stale review 1 year ago

didn't check that tests were not passing ...

cyyever marked this pull request as draft 1 year ago

SunMarc commented on 2025-05-19

cyyever force pushed from 1d36ffc0 to eb1c2d4e 1 year ago

cyyever force pushed from eb1c2d4e to a29e37b9 1 year ago

cyyever force pushed from a29e37b9 to cd8ffd7d 1 year ago

cyyever force pushed from cd8ffd7d to 367dca0b 1 year ago

cyyever changed the title ~~Better typing in src/transformers/training_args.py~~ Annotate framework in src/transformers/training_args.py 1 year ago

cyyever changed the title ~~Annotate framework in src/transformers/training_args.py~~ More typing in src/transformers/training_args.py 1 year ago

cyyever force pushed from 367dca0b to efaa553a 1 year ago

cyyever force pushed from c3c1a6b9 to d56e1ed5 1 year ago

cyyever marked this pull request as ready for review 1 year ago

SunMarc commented on 2025-05-21

Annotate `framework` in src/transformers/training_args.py

d0b29e26

Fix typing

ddb45738

Revert framework change

da80c31d

cyyever force pushed from d56e1ed5 to da80c31d 1 year ago

SunMarc enabled auto-merge (squash) 1 year ago

SunMarc approved these changes on 2025-05-22

SunMarc merged 12346833 into main 1 year ago

cyyever deleted the training_argument_checking2 branch 341 days ago

Reviewers

SunMarc

Rocketknight1

ArthurZucker

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

transformers More typing in src/transformers/training_args.py #38106 Merged

More typing in src/transformers/training_args.py #38106

transformers
More typing in src/transformers/training_args.py
#38106

Merged