transformers
fix(flaky): `test_generate_with_and_without_position_ids` in GLM ORC
#44173

Merged

fix(flaky): `test_generate_with_and_without_position_ids` in GLM ORC #44173

tarekziade merged 8 commits into main from tarekziade-fix-glm-ocr-flakiness

tarekziade assigned

tarekziade 113 days ago

tarekziade requested a review from

Rocketknight1 113 days ago

tarekziade marked this pull request as draft 113 days ago

tarekziade marked this pull request as ready for review 113 days ago

zucchini-nlp commented on 2026-02-20

fix(flaky): `test_generate_with_and_without_position_ids` in GLM ORC

df10d4c0

moved the fix to modular

af2ea605

simplify code

875c8a0b

dont tweak position ids here

cfc1321f

tarekziade marked this pull request as draft 112 days ago

improve patch so we don't alter position ids in the wrong path

893ab53a

tarekziade force pushed from 7d35dffb to 893ab53a 112 days ago

zucchini-nlp commented on 2026-02-20

reverted initial fix and skip 2D from GenerationTesterMixin.test_gene…

34e24bae

tarekziade marked this pull request as ready for review 112 days ago

Merge branch 'main' into tarekziade-fix-glm-ocr-flakiness

2a4e58e4

tarekziade requested a review from

zucchini-nlp 112 days ago

zucchini-nlp approved these changes on 2026-02-20

Merge branch 'main' into tarekziade-fix-glm-ocr-flakiness

ec02c639

tarekziade merged a3bfc8bc into main 112 days ago

tarekziade deleted the tarekziade-fix-glm-ocr-flakiness branch 112 days ago

Reviewers

zucchini-nlp

Rocketknight1

Assignees

tarekziade

Labels

None yet

Milestone

No milestone