PR #47620 Always tie embeddings for LongT5 and Pop2Piano

Always tie embeddings for LongT5 and Pop2Piano #47620

zucchini-nlp merged 10 commits into huggingface:main from jiqing-feng:fix_structural_tying

Always tie structural weights, regardless of `tie_word_embeddings`

c33715c8

Always tie structural weights, regardless of `tie_word_embeddings`

84193d14

jiqing-feng force pushed from bd66db00 to 84193d14 77 days ago

Restore pre-#41580 tying expectations for fsmt/mbart

4df04fdc

jiqing-feng marked this pull request as ready for review 77 days ago

github-actions requested a review from

ArthurZucker 77 days ago

github-actions requested a review from

Rocketknight1 77 days ago

zucchini-nlp commented on 2026-07-29

ErenAta16 commented on 2026-07-29

Add T5 tying test and document regex-form key handling

4e3835ab

Merge branch 'main' into fix_structural_tying

f071e828

Merge branch 'main' into fix_structural_tying

4d8c473a

Always tie embeddings for LongT5 and Pop2Piano

dedf76dc

ArthurZucker approved these changes on 2026-08-17

jiqing-feng changed the title ~~Always tie structural weights, regardless of `tie_word_embeddings`~~ Always tie embeddings for LongT5 and Pop2Piano 58 days ago

Shorten comments

8711660d

Merge branch 'main' into fix_structural_tying

1a27b551

Merge branch 'main' into fix_structural_tying

4bf574d3

zucchini-nlp approved these changes on 2026-08-20

zucchini-nlp enabled auto-merge 55 days ago

zucchini-nlp merged 5909a467 into main 55 days ago

Reviewers

zucchini-nlp

ArthurZucker

ErenAta16

Rocketknight1

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

transformers Always tie embeddings for LongT5 and Pop2Piano #47620 Merged

Always tie embeddings for LongT5 and Pop2Piano #47620

transformers
Always tie embeddings for LongT5 and Pop2Piano
#47620

Merged