fix: set logger for controller-runtime #1211
AlexsJones
merged
1 commit into
k8sgpt-ai:main
from
makllama:log
cf250024
approved these changes
on 2024-08-02
cf250024302 days ago👍 1
I tested the changes and it works for me. Thanks.
cf250024298 days ago
Can we put new code in pkg/server/serve.go instead of cmd/serve/serve.go?
I'm thinking this part is more related to server that cli. I tried this option prior your PR and it also works.
AlexsJones297 days ago
Can we put new code in pkg/server/serve.go instead of cmd/serve/serve.go? I'm thinking this part is more related to server that cli. I tried this option prior your PR and it also works.
I would be supportive of that also
AlexsJones
requested changes
on 2024-08-07
AlexsJones297 days ago
Please move this into the pkg/server/serve.go
fix: set logger for controller-runtime
29a029ba
yeahdongcn297 days ago
Please move this into the
pkg/server/serve.go
Done. @cf250024 @AlexsJones
AlexsJones
approved these changes
on 2024-08-07
Login to write a write a comment.
Closes #1208
📑 Description
Set logger for controller-runtime.
✅ Checks
ℹ Additional Information
Testing done:
make docker-build-> ok[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.is no longer present.