llvm-project
4f5d866a - [llvm-lit] Add REQUIRES: shell to BOLT permission test for lit internal shell (#103012)

Commit
1 year ago
[llvm-lit] Add REQUIRES: shell to BOLT permission test for lit internal shell (#103012) This patch adds the `REQUIRES: shell` directive to the BOLT permission test to ensure it only runs in environments with a full-featured Unix-like shell. This change is necessary because the test relies on advanced shell capabilities that are not supported by lit's internal shell. **Reasoning:** The BOLT permission test uses features like running commands in the background with `&`, performing arithmetic operations, and handling special number formats (octal). These features require a more capable shell than what lit's internal shell provides. Without a proper shell, the test could fail or behave unpredictably. This change is relevant for enabling the lit internal shell by default, as outlined in [[RFC] Enabling the Lit Internal Shell by Default](https://discourse.llvm.org/t/rfc-enabling-the-lit-internal-shell-by-default/80179)
Author
Parents
Loading