llvm-project
[RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules
#104512

Merged

[RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules #104512

dmpolukhin merged 12 commits into llvm:main from dmpolukhin:assert-not-instantiated-in-scope-cxx-modules

dmpolukhin requested a review from

zygoloid 1 year ago

dmpolukhin requested a review from

ChuanqiXu9 1 year ago

llvmbot added clang

llvmbot added clang:frontend

llvmbot added clang:modules

ChuanqiXu9 commented on 2024-08-16

dmpolukhin marked this pull request as draft 1 year ago

dmpolukhin marked this pull request as ready for review 1 year ago

dmpolukhin marked this pull request as draft 1 year ago

dmpolukhin force pushed to 90de760b 1 year ago

[RFC][C++20][Modules] Fix crash when function and lambda inside loade…

87727955

[RFC][C++20][Modules] Fix crash when function and lambda inside loade…

524344e1

Try different approach withreverse order of loading specializations

f5606eb5

Fix clang-format issue

11b798d5

Visit lambdas right after FunctionDecl

1fc4693a

Fix a warning for -Wcovered-switch-default (#105054)

64230ad7

Add minimal reroducer for the crash after changing deserialization order

4a964a71

Fix a warning for -Wcovered-switch-default (#105054)

01375e31

[flang][cuda] Add missing dependency (#106298)

2b588e5d

Fix a warning for -Wcovered-switch-default (#105054)

db65f698

Delay loading lambdas

b5f6a30e

dmpolukhin force pushed from 90de760b to b5f6a30e 1 year ago

dmpolukhin marked this pull request as ready for review 1 year ago

ChuanqiXu9 commented on 2024-09-09

Comments resolved

bd6386f2

ChuanqiXu9 approved these changes on 2024-09-10

dmpolukhin merged d778689f into main 1 year ago

dmpolukhin deleted the assert-not-instantiated-in-scope-cxx-modules branch 1 year ago

ChuanqiXu9 commented on 2024-09-12

Reviewers

ChuanqiXu9

zygoloid

Assignees

No one assigned

Labels

clang clang:frontend clang:modules

Milestone

No milestone

llvm-project [RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules #104512 Merged

[RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules #104512

llvm-project
[RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules
#104512

Merged