llvm-project
[VPlan] Implement VPlan-based cost model for VPReduction, VPExtendedReduction and VPMulAccumulateReduction.
#113903

Merged

[VPlan] Implement VPlan-based cost model for VPReduction, VPExtendedReduction and VPMulAccumulateReduction. #113903

ElvisWang123 merged 61 commits into llvm:main from ElvisWang123:vp-arm-mve-transform

ElvisWang123 requested a review from

fhahn 1 year ago

ElvisWang123 requested a review from

arcbbb 1 year ago

ElvisWang123 requested a review from

davemgreen 1 year ago

ElvisWang123 requested a review from

ayalz 1 year ago

llvmbot added vectorizers

llvmbot added llvm:transforms

davemgreen requested a review from

david-arm 1 year ago

ElvisWang123 force pushed from 442d1dd7 to bcccb133 1 year ago

fhahn commented on 2024-11-08

ElvisWang123 force pushed from bcccb133 362 days ago

ElvisWang123 force pushed to 234e81ee 362 days ago

davemgreen commented on 2024-11-12

fhahn commented on 2024-11-13

ElvisWang123 force pushed to e4aa4f3a 358 days ago

ElvisWang123 force pushed to 9f099300 348 days ago

ElvisWang123 force pushed from 9f099300 to ffeccf46 340 days ago

[VPlan] Impl VPlan-based pattern match for ExtendedRed and MulAccRed.…

33b1f601

Partially support Extended-reduction.

68fbd704

Support MulAccRecipe

c8c9d564

Fix servel errors and update tests.

d29a1189

Refactors

e5b50f78

Fix typos and update printing test

cc004ffd

Fold reduce.add(zext(mul(sext(A), sext(B)))) into MulAccRecipe when A…

b5445ca7

Refactor! Reuse functions from VPReductionRecipe.

1df91d49

Refactor! Add comments and refine new recipes.

a0b2f30c

Remove underying instruction dependency.

46928bdc

Revert "Remove underying instruction dependency."

35abf19f

Remove extended instruction after mul in MulAccRecipe.

453997e4

Refactor.

fa4f476c

Clamp the range when the ExtendedReduction or MulAcc cost is invalid.

86ad2d85

Try to not depend on underlying ext/mul instructions and preserve fla…

594f9e49

Update testcase and fix reduction cost.

52369d05

!fixup. Rebase to upstream `prepareToExecute()` implementation.

abc08f39

ElvisWang123 force pushed from ffeccf46 to abc08f39 338 days ago

fhahn commented on 2024-12-09

Move VPReductionRecipe inherite from VPRecipeWithIRFlags.

729a70ea

Only create VPMulAcc/VPExtendedReduction recipe when beneficial. NFC

ea58282b

Merge branch 'main' into vp-arm-mve-transform

1c22ce2a

alexey-bataev commented on 2024-12-11

!fixup use `auto`

a9874560

!fixup VPReductionRecipe unit tests.

6c434c73

fhahn commented on 2024-12-20

!fixup migrate tryTo* to VPlanTransforms

f4b1b78f

Implement clone() and add some docs.

bffcac5d

Update comments.

da705f1b

fix-ReductionEVLRecipe query underlyingInstr().

1dc279ef

Merge branch 'main' into vp-arm-mve-transform

20ea82e7

Update after merge.

90f9ffab

alexey-bataev commented on 2024-12-24

Address comments and split off abstract recipes creation from adjustR…

99512fed

alexey-bataev commented on 2024-12-26

!fixup using foldTailWithEVL.

2e4014a9

fhahn commented on 2025-01-05

!fixup, remove extra debugLoc and move check of EVL out of transforms.

38dd9245

ElvisWang123 requested a review from

DeinAlptraum 291 days ago

ElvisWang123 requested a review from

aaupov 291 days ago

ElvisWang123 requested a review from

maksfb 291 days ago

ElvisWang123 requested a review from

rafaelauler 291 days ago

ElvisWang123 requested a review from

ayermolo 291 days ago

ElvisWang123 requested a review from

dcci 291 days ago

ElvisWang123 requested a review from

yota9 291 days ago

ElvisWang123 requested a review from

JDevlieghere 291 days ago

ElvisWang123 requested a review from

lanza 291 days ago

ElvisWang123 requested a review from

bcardosolopes 291 days ago

ElvisWang123 requested a review from

Endilll 291 days ago

ElvisWang123 requested a review 291 days ago

ElvisWang123 force pushed to 38dd9245 291 days ago

ElvisWang123 removed review request 291 days ago

ElvisWang123 removed review request from

maksfb 291 days ago

ElvisWang123 removed review request from

bcardosolopes 291 days ago

ElvisWang123 removed review request from

Endilll 291 days ago

ElvisWang123 removed review request from

lanza 291 days ago

ElvisWang123 removed review request from

DeinAlptraum 291 days ago

ElvisWang123 removed review request from

JDevlieghere 291 days ago

ElvisWang123 removed review request from

yota9 291 days ago

ElvisWang123 removed review request from

aaupov 291 days ago

ElvisWang123 removed review request from

rafaelauler 291 days ago

ElvisWang123 removed review request from

ayermolo 291 days ago

ElvisWang123 removed review request from

dcci 291 days ago

Merge branch 'main' into vp-arm-mve-transform

602a5e4e

Update after merge main.

1939d44c

Merge branch 'main' into vp-arm-mve-transform

2ee6e76b

Update after merge. Using runPass::().

d584fc1f

fhahn commented on 2025-02-22

!fixup, Remove unused check and functions.

21b33e67

alexey-bataev commented on 2025-03-04

Merge branch 'main' into vp-arm-mve-transform

ae371e50

!fixup; Address comments.

0d7b7f33

ElvisWang123 changed the title ~~[VPlan] Impl VPlan-based pattern match for ExtendedRed and MulAccRed (NFCI)~~ [VPlan] Impl VPlan-based pattern match for ExtendedRed and MulAccRed 249 days ago

!fixup, Add Mul cost to prevent FMuladd Reduction cost misaligned.

e12bd048

davemgreen commented on 2025-03-09

!Fixup, typo.

4906637b

fhahn commented on 2025-03-10

Merge branch 'main' into vp-arm-mve-transform

ca5db100

!fixup, Address comments and fix VPReductionRecipe::computeCost

2fbdc7ca

ElvisWang123 commented on 2025-03-19

Merge branch 'main' into vp-arm-mve-transform

38d83bfc

Merge branch 'main' into vp-arm-mve-transform

3e2acadd

!fixup, Update after merge, using std::array.

d2a5a432

fixup, formatting.

484f9cce

fhahn commented on 2025-03-19

!fixup, address comments.

cd86af41

lukel97 commented on 2025-03-20

fhahn commented on 2025-03-24

Merge branch 'main' into vp-arm-mve-transform

84f8a464

!fixup, formatting and address comments.

36e10329

ElvisWang123 commented on 2025-03-25

SamTebbs33 requested a review from

SamTebbs33 226 days ago

fhahn commented on 2025-04-02

!fixup, Update inferScalarType and not clear the VF of plan.

2483a29d

sdesmalen-arm commented on 2025-04-10

!fixup, address comments.

56dcd904

fhahn commented on 2025-04-11

sdesmalen-arm commented on 2025-04-11

Merge branch 'main' into vp-arm-mve-transform

26d938a2

!fixup, address comments.

b32538f4

fhahn commented on 2025-04-21

fhahn commented on 2025-04-22

SamTebbs33 commented on 2025-04-22

!fixup, address comments and using `transferFlags()` to copy nneg.

fd539f86

sdesmalen-arm requested changes on 2025-04-23

!fixup, address comments.

71c74013

sdesmalen-arm approved these changes on 2025-04-23

fhahn commented on 2025-04-23

!fixup, Add new recipes to mayReadWriteMemory.

7da7983f

fhahn commented on 2025-04-27

Merge branch 'main' into vp-arm-mve-transform

f4afc2c7

Fixup after merge.

7b257671

ElvisWang123 commented on 2025-05-19

ElvisWang123 changed the title ~~[VPlan] Impl VPlan-based pattern match for ExtendedRed and MulAccRed~~ [VPlan] Implement VPlan-based cost model for VPReduction, VPExtendedReduction and VPMulAccumulateReduction. (NFC) 173 days ago

sdesmalen-arm approved these changes on 2025-05-27

fhahn approved these changes on 2025-05-27

Merge branch 'main' into vp-arm-mve-transform

685f2173

Address comments.

710df444

Merge branch 'main' into vp-arm-mve-transform

829cb2a9

ElvisWang123 changed the title ~~[VPlan] Implement VPlan-based cost model for VPReduction, VPExtendedReduction and VPMulAccumulateReduction. (NFC)~~ [VPlan] Implement VPlan-based cost model for VPReduction, VPExtendedReduction and VPMulAccumulateReduction. 163 days ago

ElvisWang123 merged 332fe08f into main 163 days ago

ElvisWang123 deleted the vp-arm-mve-transform branch 163 days ago

Reviewers

fhahn

sdesmalen-arm

SamTebbs33

lukel97

davemgreen

alexey-bataev

arcbbb

ayalz

david-arm

Assignees

No one assigned

Labels

vectorizers llvm:transforms

Milestone

No milestone

llvm-project [VPlan] Implement VPlan-based cost model for VPReduction, VPExtendedReduction and VPMulAccumulateReduction. #113903 Merged

[VPlan] Implement VPlan-based cost model for VPReduction, VPExtendedReduction and VPMulAccumulateReduction. #113903

llvm-project
[VPlan] Implement VPlan-based cost model for VPReduction, VPExtendedReduction and VPMulAccumulateReduction.
#113903

Merged