llvm-project
[mlir] Make `TypedStrAttr` actually enforce the string type.
#124770
Merged

[mlir] Make `TypedStrAttr` actually enforce the string type. #124770

ingomueller-net
ingomueller-net [mlir] Make `TypedStrAttr` actually enforce the string type.
12b9d9bb
ingomueller-net ingomueller-net requested a review from jpienaar jpienaar 249 days ago
ingomueller-net ingomueller-net requested a review from ftynse ftynse 249 days ago
ingomueller-net ingomueller-net requested a review from matthias-springer matthias-springer 249 days ago
ingomueller-net ingomueller-net requested a review from joker-eph joker-eph 249 days ago
llvmbot llvmbot added mlir:core
llvmbot llvmbot added mlir
llvmbot llvmbot added mlir:ods
llvmbot
ingomueller-net
ingomueller-net commented on 2025-01-28
ingomueller-net Fix possible crash by testing for `isa<StringAttr` first.
902cc533
matthias-springer
matthias-springer approved these changes on 2025-01-29
ingomueller-net Extend tests that applies new constraint non-`StringAttr` attribute.
d6648ffb
ingomueller-net ingomueller-net merged 8d6b2416 into main 249 days ago
ingomueller-net ingomueller-net deleted the typed-str-attr branch 249 days ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone