llvm-project
[HLSL] Adding support for Root Constants in LLVM Metadata
#135085
Merged

[HLSL] Adding support for Root Constants in LLVM Metadata #135085

joaosaffran
adding rootsignature to obj2yaml
526b34a5
adding test
e84a8e1d
removing old test
f25fd64e
remove useless includes
16552f0e
addressing comments
a6eb4c04
updating test
7d080b30
removing useless header
504527b0
fix formating
24256722
renaming test
08c17bbd
addressing pr comments
395a5367
adding str to ROOT_ELEMENT_FLAG
f93dff92
formating
1c1edb8e
refactoring to follow llvm standards
5bef775a
addressing comments
628545a1
clean up
c5c2ab6d
remove version
b9db72cb
fix pr
f4af0437
adding dxil-dis test
496b922e
adding compatibility test
422578ff
addressing test concerns
b1423eb7
clean up
b6262b67
addressing comments
16d0e8ef
adding fail test
0a9e4689
adding comment
82950318
adding few more tests
c8e1e388
format
434b862b
cleanup
2bfc5ad0
adding metadata extraction
479422d3
moving root signature to it's own pass
f61ee775
formating
499d8796
removing useless imports
c4af535b
fixing pr changes
819fa0d1
adding some asserts
d347a87b
format
d8824ed9
fixing assert
25c03846
cleaning
5eb0ad25
clean up
559427db
addressing comments
8ca5b2ac
removing version
d52cd2c0
fix test
5930dcb8
addressing PR Comments
fc72988d
fix test
2d1ee0d1
filtering root signatures not associated with entry function
92a85fe6
separating parsing and validation
979ee915
improve error handling
d0896744
clean up
980e7d92
clean up
04667f3f
formating
8ec40aae
addressing comments and fix tests
b0ac6bec
formating
6a365038
addressing pr comments
f7d2c124
addressing PR comments
d6c98edf
addressing pr comments
36746f5b
removing copies from root signature use in dx container globals
b5208e86
adding more tests
1fd65680
maybe fix test?
cde46348
try fix format
4410e7bf
removing test
cbdb114c
adding llvm unreachable and testing test
667ee175
stopping compilation if root signature error were emitted
d0dae8b6
making sure Error tests fail
b1b28f86
adding root constants
0efd8cc1
refactoring root signature analysis to return a map instead
11256d87
addressing pr comments
3c5046e7
clean up
5d4505c5
addressing pr comments
3117530c
implementing find interface for RootSignatureAnalysisWrapper
0af845c4
adding test for null function
bf49a3ad
fix root signature test error
78826a5b
fix other functions are checked
4e689e91
adding missing continue
b0d0180d
adding few more tests
3c6894f7
adding yaml2obj support
08f6ddc5
adding support for obj2yaml and initial tests
b2329676
multiple parameters support and more testing
1026a8e1
clean up
00175bf1
fixing formating
9ed2adc0
reapply rebase fix
e8252ba0
clean up
4de5c298
addressing pr comments
fe13b616
first working version
767b7d02
formating
8434dc2f
moving the offset logic to it's own class
d3917278
refactoring to remove use of map and string
68c7513d
addressing comments
23069ab6
using buffer_ostream
d14471b1
remove getsize
216341ca
clean up
85f012c3
clean up
1e2bcf54
clean up
0e277d96
clean up
5cd0044c
addressing pr comments
7a7c34d5
clean up
d3fafab7
Merge branch 'refactor/improve-offset-calculation' into users/joaosaf…
15d1a8ca
clean up
74856401
moving initializer arround
17abc829
addressing pr comments
4b177e26
addressing changes
ec1dd871
Merge branch 'main' into users/joaosaffran/127840
eb9d7d39
fix test
f2a4f04a
refactoring to change representations in binary format
7c4236cd
addressing pr comments
2894f964
addressing comments and clean up
7b5e9d8f
moving RootSignatureValidations to out of BinaryFormat
f0e6a46f
addressing most pr comments
4fe30dfa
adding root parameter view
cbc334aa
clean up
31bcd739
addressing pr comments
30098e1f
wip: implementing comments
1bf6408d
removing old code
d1b32f3c
address errors
3b9bf271
removing validations from obj2yaml
89632a4e
ac
67da709d
address comments
3991c5d9
clean up
cfc6bfb3
removing param_header_begin and param_header_end
82a31fad
adding support for root constants in metadata generation
9b59d010
add test
efc5e52b
joaosaffran joaosaffran assigned bogner bogner 213 days ago
joaosaffran joaosaffran assigned inbelic inbelic 213 days ago
llvmbot llvmbot added backend:DirectX
llvmbot
Revert "clean up"
e6865a76
Reapply "clean up"
021976d8
removing unnecessary parameters
102ff4be
addressing pr comments
39d4b085
adding more tests
7343d953
adding more tests and addressing comments
69869451
inbelic
inbelic commented on 2025-04-14
adding tests and changing parameter type
c0ac522c
Merge branch 'obj2yaml/root-constants' into metadata/root-constants
cadc2967
address comments
c4b78d88
address comments
8bdc206e
joaosaffran joaosaffran requested a review from inbelic inbelic 208 days ago
addressing pr comments
1e5eee54
llvmbot llvmbot added llvm:binary-utilities
Revert "addressing pr comments"
a968d81f
address comments
8511fa99
changing back enums to enum class
330369ab
addressing PR comments and adding more tests
d747bcc6
adding tests and fixing code
6cef5677
addressing comments
246d5d3d
inbelic
inbelic commented on 2025-04-16
clean up
bb6c0cfe
Merge branch 'obj2yaml/root-constants' into metadata/root-constants
2203885f
fixing bugs
7aed7d1f
addressing nits
7885eed9
joaosaffran joaosaffran changed the base branch from users/joaosaffran/127840 to main 205 days ago
joaosaffran joaosaffran marked this pull request as draft 205 days ago
joaosaffran joaosaffran force pushed to 7aed7d1f 205 days ago
Merge branch 'obj2yaml/root-constants' into metadata/root-constants
f315bb4b
Merge branch 'main' into metadata/root-constants
193a80bc
joaosaffran joaosaffran marked this pull request as ready for review 205 days ago
joaosaffran joaosaffran requested a review from inbelic inbelic 205 days ago
inbelic
inbelic commented on 2025-04-17
joaosaffran joaosaffran requested a review from bogner bogner 199 days ago
bogner
bogner commented on 2025-04-24
addressing pr comments
578faea7
joaosaffran joaosaffran requested a review from bogner bogner 198 days ago
joaosaffran joaosaffran requested a review from inbelic inbelic 198 days ago
bogner
bogner commented on 2025-04-24
addressing comments
860fddd1
joaosaffran joaosaffran requested a review from bogner bogner 198 days ago
bogner
bogner approved these changes on 2025-04-24
inbelic
inbelic approved these changes on 2025-04-24
joaosaffran joaosaffran merged b649b355 into main 198 days ago
llvm-ci
joaosaffran joaosaffran deleted the metadata/root-constants branch 193 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
Labels
Milestone