llvm-project
[HLSL][RootSignature] Correct `RootSignatureParser` to use correct `SourceLocation` in diagnostics
#147084

Merged

[HLSL][RootSignature] Correct `RootSignatureParser` to use correct `SourceLocation` in diagnostics #147084

inbelic merged 10 commits into llvm:main from inbelic:inbelic/rs-fix-lexer

inbelic commented on 2025-07-04

inbelic force pushed 169 days ago

nfc: add phony ASTContext and StringLiteral to ParseHLSL

34d38790

nfc: add StringLiteral as a member of RootSignatureParser

d84d2872

update `RootSignatureToken` to hold the offset into the signature string

93519464

nfc: instantiate Lexer in Parser constructor

dece8af0

add sample testcase

b953140a

rebase: clean-ups

1a64eff5

inbelic force pushed to 1a64eff5 169 days ago

inbelic marked this pull request as ready for review 169 days ago

llvmbot added clang

llvmbot added clang:frontend

llvmbot added HLSL

llvm-beanz approved these changes on 2025-07-07

review: remove unneeded namespacing

7da53d21

review: improve flag

0132e74d

review: specify column value as well

d4cf62dc

nfc, self-review: simplify diag reporting with helper function

29cde653

bogner approved these changes on 2025-07-08

inbelic merged 3dec46d9 into main 165 days ago

inbelic deleted the inbelic/rs-fix-lexer branch 159 days ago

Reviewers

bogner

llvm-beanz

Assignees

No one assigned

Labels

clang clang:frontend HLSL

Milestone

No milestone