llvm-project
[DirectX] Adding missing descriptor table validations
#153276
Merged

[DirectX] Adding missing descriptor table validations #153276

joaosaffran
refactoring
0e8828c2
refactoring
2edd215e
clean up
242545e5
format
3f8dec41
formating
3b1ce3be
fix import issues
f5720afd
formating
ea54904c
refactoring
a49aa192
init refactoring
d90676fe
adding validation
a04eb9ff
clean
5994b8f8
implementing
e8b14bf3
finish implementing && fix tests
8f40e83a
fix issue
28350b2d
sync parent
4fd2e0bf
sync parent
e25ee871
add validation
01a558be
address comments
881dd365
Merge branch 'refactoring/updating-return-root-sig-analysis' into val…
8779ee95
adding validation
43eb04ec
fix test
c16f15b4
Merge branch 'validation/check-descriptors-are-bound' into validation…
f67bec1d
format
d7b4cf44
format
c7d5be77
address changes
cc5afaef
fix tests
571a0ef2
Merge branch 'refactoring/updating-return-root-sig-analysis' into val…
974d4bca
Merge branch 'validation/check-descriptors-are-bound' into validation…
403b546b
fix test
aea75dac
add preserved
e0bc8623
addressing comments
b5a0b32a
Merge branch 'main' into validation/check-descriptors-are-bound
00a74af8
updating
5ccb842c
format
5423aba8
adding tests
a7637a78
clean up
da42c0c2
update
5af91995
Merge branch 'validation/check-descriptors-are-bound' into validation…
46294cb8
clean up
91ff1bf5
address comments
edb015dc
Merge branch 'validation/check-descriptors-are-bound' into validation…
5f8bbeb5
adding root constants
9f3888ea
Merge branch 'validation/check-descriptors-are-bound' into validation…
8459d143
clean
578a03bd
Merge branch 'validation/check-descriptors-are-bound' into validation…
34deb3af
moving code arround
b4a0e16b
Merge branch 'validation/check-descriptors-are-bound' into validation…
49f3bf21
clean
ef146380
addressing comments
662c3a84
address comments
848501da
format test
8d97116d
fix test
9c34f3fd
Merge branch 'validation/check-descriptors-are-bound' into validation…
24040a03
addressing comments
2c30cd90
address comments
260633c5
Merge branch 'main' into validation/check-descriptors-are-bound
d42f1565
Merge branch 'main' into validation/check-descriptors-are-bound
9ee3a4b1
update code
6db62247
cleanup
04658b81
address comments from inbelic
adf3feb8
refactoring
c95ce686
add tests
af6aa531
cleanup
29eb893b
clean
ed4c5539
clean up
28fb6092
Merge branch 'validation/overlapping-ranges' into validation/check-de…
fc338b58
clean
f5b5b3e8
clean?
03d571a0
Merge branch 'validation/check-descriptors-are-bound' into validation…
76048d47
clean?
7c9bd624
format
ef51048d
formating
21675e61
format
849ff861
format
7a1bc21b
joaosaffran-zz addressing comments from bogner and inbelic
403972db
joaosaffran-zz clean up
0f0435d6
joaosaffran-zz clean up
e841a98b
joaosaffran-zz fix build
ae6d67a1
joaosaffran-zz fix tests
41f32bd5
Merge branch 'validation/overlapping-ranges' into validation/check-de…
47662f0f
format
6da5fb01
Merge branch 'validation/check-descriptors-are-bound' into validation…
108a7d57
Merge branch 'main' into validation/overlapping-ranges
6f3d019e
Merge branch 'main' into validation/overlapping-ranges
971ad57a
update
db73d716
address comment from inbelic
3b04c2d0
address comments 2
1ddffc3c
fix merge mess
1c10acf8
check if table mix samplers with others
50e78d28
validating register not overflow in table
aee4c564
clean
7d1c13ee
llvmbot llvmbot added backend:DirectX
llvmbot
github-actions
format
85719afb
github-actions
format
cc304fd4
fix typo
3c281422
clean
81261ff4
inbelic
inbelic commented on 2025-08-12
addressing comments from inbelic
db0008ec
addressing inbelic comments
0c72dcfc
adding test
b4e5fb4e
address comments
e5e73feb
llvmbot llvmbot added HLSL
address comments
ad0e1f3f
Merge branch 'validation/descriptor-tables' of https://github.com/joa…
d97eb7cf
fix comment
8a4ee3c7
addressing comments from bogner
4a655a54
addressing comments
cc94561c
address comments
98f48d25
refactoring
eb334b89
addressing comments
06c0da45
Merge branch 'main' into validation/overlapping-ranges
d58606fc
fix test
74980c89
addressing comment
23537b5f
address comments
d376abf1
Merge branch 'validation/overlapping-ranges' into validation/check-de…
4abb40d0
fix test
bb44eef7
Merge branch 'main' into validation/check-descriptors-are-bound
1cf2d1e6
clean up
373d871f
format
d2750d7b
Merge branch 'validation/check-descriptors-are-bound' into validation…
777d544b
fix merge oopsi
19e9baac
format
708c4dc8
clean up
a163d1b5
clean up tests
4f120ccf
Merge
def929fd
clean up
d3349cec
moving code to where I think make sense
bf5714d7
format
7cf513f0
format
fe246374
inbelic
joaosaffran refactoring to not create extra space
6db8d93a
joaosaffran remove copy of binding
e3a65b66
joaosaffran making BindingRange const
e902add6
joaosaffran doing it again for other isBound
9a6d64c5
joaosaffran adding DXILResourceTypeMap
15b75920
joaosaffran updating error messages and tests
11b9fb21
joaosaffran Merge branch 'validation/check-descriptors-are-bound' into validation…
0b8a997a
joaosaffran moving offset logic into shared validations
34619da2
inbelic
inbelic commented on 2025-08-25
joaosaffran refactoring suggested by inbelic
84d45798
joaosaffran joaosaffran requested a review from inbelic inbelic 36 days ago
inbelic
inbelic commented on 2025-08-25
joaosaffran adding multiple error messages
d2b4aea9
joaosaffran joaosaffran requested a review from inbelic inbelic 36 days ago
inbelic
inbelic commented on 2025-08-26
joaosaffran removing StartSlot
e2ba167e
joaosaffran removing unecessary code
b395a47a
joaosaffran Merge branch 'main' into validation/textures-not-bind-root-signatures
17b425dc
joaosaffran refactoring
f9c4b9c2
joaosaffran adding comment
c7cedb42
joaosaffran refactoring isBound to return the bound reg
bf9b30c1
joaosaffran formating
18e4c3d1
joaosaffran Merge branch 'validation/textures-not-bind-root-signatures' into vali…
567bd159
joaosaffran
joaosaffran commented on 2025-08-30
joaosaffran clean up
42518b24
joaosaffran
joaosaffran commented on 2025-08-30
joaosaffran clean up
f6abbf71
joaosaffran clean up
2971f5fc
joaosaffran clean up: self review
f0ed242c
joaosaffran clean up self review
a6a9fe9a
joaosaffran
joaosaffran commented on 2025-08-30
inbelic
inbelic commented on 2025-09-05
joaosaffran remove optional from type
3f833088
joaosaffran changing small string size
8daa97ba
joaosaffran fixing tests
79f1f487
joaosaffran removing type from handlefrombinding
3d10d92f
joaosaffran Merge branch 'main' into validation/textures-not-bind-root-signatures
f596ad57
joaosaffran renamig tests
55c2b96b
joaosaffran Merge branch 'validation/textures-not-bind-root-signatures' of https:…
d1c31f1a
joaosaffran Merge branch 'validation/textures-not-bind-root-signatures' into vali…
75d74ed8
joaosaffran refactoring to use existing funcs
fbf67767
joaosaffran joaosaffran requested a review from DeinAlptraum DeinAlptraum 20 days ago
joaosaffran joaosaffran requested a review from JDevlieghere JDevlieghere 20 days ago
joaosaffran joaosaffran requested a review from cyndyishida cyndyishida 20 days ago
joaosaffran joaosaffran requested a review from aaupov aaupov 20 days ago
joaosaffran joaosaffran requested a review from maksfb maksfb 20 days ago
joaosaffran joaosaffran requested a review from rafaelauler rafaelauler 20 days ago
joaosaffran joaosaffran requested a review from ayermolo ayermolo 20 days ago
joaosaffran joaosaffran requested a review from yota9 yota9 20 days ago
joaosaffran joaosaffran requested a review from paschalis-mpeis paschalis-mpeis 20 days ago
joaosaffran joaosaffran requested a review from yozhu yozhu 20 days ago
joaosaffran joaosaffran requested a review from lanza lanza 20 days ago
joaosaffran joaosaffran requested a review from bcardosolopes bcardosolopes 20 days ago
joaosaffran joaosaffran requested a review from xlauko xlauko 20 days ago
joaosaffran joaosaffran requested a review from andykaylor andykaylor 20 days ago
joaosaffran joaosaffran requested a review from nikic nikic 20 days ago
joaosaffran joaosaffran requested a review 20 days ago
joaosaffran joaosaffran requested a review 20 days ago
joaosaffran joaosaffran changed the base branch from users/joaosaffran/147573 to main 20 days ago
joaosaffran joaosaffran removed review request from JDevlieghere JDevlieghere 20 days ago
joaosaffran joaosaffran removed review request from aaupov aaupov 20 days ago
joaosaffran joaosaffran removed review request from maksfb maksfb 20 days ago
joaosaffran joaosaffran removed review request from rafaelauler rafaelauler 20 days ago
joaosaffran joaosaffran removed review request from cyndyishida cyndyishida 20 days ago
joaosaffran joaosaffran removed review request from DeinAlptraum DeinAlptraum 20 days ago
joaosaffran joaosaffran removed review request from ayermolo ayermolo 20 days ago
joaosaffran joaosaffran removed review request from yota9 yota9 20 days ago
joaosaffran joaosaffran removed review request from paschalis-mpeis paschalis-mpeis 20 days ago
joaosaffran joaosaffran removed review request from yozhu yozhu 20 days ago
joaosaffran joaosaffran removed review request from lanza lanza 20 days ago
joaosaffran joaosaffran removed review request from bcardosolopes bcardosolopes 20 days ago
joaosaffran joaosaffran removed review request from xlauko xlauko 20 days ago
joaosaffran joaosaffran removed review request from andykaylor andykaylor 20 days ago
joaosaffran joaosaffran removed review request from nikic nikic 20 days ago
joaosaffran joaosaffran removed review request 20 days ago
joaosaffran joaosaffran removed review request 20 days ago
joaosaffran joaosaffran marked this pull request as draft 20 days ago
joaosaffran Merge branch 'main' into validation/descriptor-tables
5f429d22
joaosaffran clean up
5633433a
joaosaffran Merge branch 'validation/descriptor-tables' of https://github.com/joa…
ec10db85
joaosaffran clean up
b42630a7
joaosaffran improve comment message
bce1ef97
joaosaffran clean up
cf84fcf5
joaosaffran
joaosaffran commented on 2025-09-10
joaosaffran joaosaffran requested a review from inbelic inbelic 20 days ago
joaosaffran joaosaffran requested a review from bogner bogner 20 days ago
joaosaffran joaosaffran marked this pull request as ready for review 20 days ago
inbelic
inbelic approved these changes on 2025-09-11
joaosaffran making updateOngoingOffset shared
e5976eef
joaosaffran refactoring
eb84e140
joaosaffran formating
6a3c2ab5
joaosaffran
joaosaffran commented on 2025-09-11
joaosaffran Merge branch 'main' into validation/descriptor-tables
1327b740
bogner
bogner commented on 2025-09-17
joaosaffran addressing comments from bogner
c2d39ed4
joaosaffran joaosaffran requested a review from bogner bogner 13 days ago
inbelic
inbelic commented on 2025-09-17
joaosaffran adding edge case test
592dc62e
joaosaffran changing frontend check back to what it was
f3253edd
joaosaffran removing some copies
d442625f
joaosaffran adding same test as frontend
f785d256
bogner
bogner approved these changes on 2025-09-23
inbelic
inbelic requested changes on 2025-09-23
joaosaffran
joaosaffran commented on 2025-09-23
refactor to copy frontend
eefd22c7
Merge branch 'main' into validation/descriptor-tables
0c508d8c
fix test and change error message
b188df17
inbelic
inbelic approved these changes on 2025-09-24
joaosaffran format
dabb9cd6
joaosaffran format
0e08ceab
joaosaffran joaosaffran merged c06f3542 into main 4 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
Milestone