llvm-project
[libc++] Implement P2988R12: `std::optional<T&>`
#155202
Merged
Overview
Commits
39
Changes
View On GitHub

[libc++] Implement P2988R12: `std::optional<T&>` #155202

frederick-vs-ja merged 39 commits into llvm:main from smallp-o-p:implement-P2988R12
smallp-o-p
smallp-o-p smallp-o-p requested a review 301 days ago
llvmbot llvmbot added libc++
llvmbot
github-actions
github-actions
smallp-o-p smallp-o-p marked this pull request as draft 301 days ago
frederick-vs-ja
frederick-vs-ja commented on 2025-08-25
H-G-Hristov
H-G-Hristov commented on 2025-08-25
smallp-o-p smallp-o-p changed the title [libc++] Implement P2988R12: `std::optional<T&> [libc++] Implement P2988R12: `std::optional<T&>` 300 days ago
smallp-o-p smallp-o-p force pushed 270 days ago
smallp-o-p smallp-o-p force pushed 270 days ago
smallp-o-p smallp-o-p marked this pull request as ready for review 269 days ago
smallp-o-p
vogelsgesang
smallp-o-p
frederick-vs-ja
frederick-vs-ja
frederick-vs-ja requested changes on 2025-09-26
smallp-o-p
Zingam
smallp-o-p
frederick-vs-ja
frederick-vs-ja commented on 2025-10-23
smallp-o-p smallp-o-p force pushed 241 days ago
frederick-vs-ja
frederick-vs-ja approved these changes on 2025-10-26
frederick-vs-ja
frederick-vs-ja requested changes on 2025-10-26
smallp-o-p
smallp-o-p Augment tests
72bb6e9b
smallp-o-p formatting
df2e9e76
smallp-o-p Forgot to gate a test
322079d5
smallp-o-p Update generated files
2a014d8b
smallp-o-p Formatting
294cb8e9
smallp-o-p Update documentation
762bb8cd
smallp-o-p Update optional to allow T&, disable iterator and value_or for T(&)()
223ce490
smallp-o-p Remove nullptr dereference in iterator
92137cb8
smallp-o-p Left in an extraneous paren
c1235517
smallp-o-p Python formatting
90754420
smallp-o-p Fix merge oops
0ca1d516
smallp-o-p Formatting and include
4ba0c8f7
smallp-o-p Gate ref tests, use std::same_as suggestion
660716c6
smallp-o-p Fix GCC shadow warning
717c5f9a
smallp-o-p Add constraint to emplace, add deleted optional<T&> constructors, add…
1612378e
smallp-o-p Remove __can_bind_reference() in favor of __reference_constructs_from…
ea6ce10b
smallp-o-p Assignment shouldn't modify the underlying value, test for that and a…
089cb713
smallp-o-p Clang-Format
c6028985
smallp-o-p Address comments + Add some tests for function refs and array refs
42637ff9
smallp-o-p Change a few more static_asserts
3c9c51b6
smallp-o-p Fix up swap, make_optional, add tests
dfb33493
smallp-o-p Address nits
bc683103
smallp-o-p Formatting
4f874380
smallp-o-p Formatting x2
e586acd2
smallp-o-p Fix typo
18c1b96c
frederick-vs-ja
smallp-o-p
frederick-vs-ja
smallp-o-p Allow make_optional for T&, add test
1add5c55
smallp-o-p smallp-o-p force pushed to 1add5c55 237 days ago
smallp-o-p Formatting
85db654f
Zingam
Zingam commented on 2025-10-31
smallp-o-p Use std::swap, mark T& assignment and __swap noexcept
65e92c48
frederick-vs-ja
frederick-vs-ja approved these changes on 2025-11-01
frederick-vs-ja frederick-vs-ja requested a review from ldionne ldionne 233 days ago
frederick-vs-ja frederick-vs-ja requested a review from Zingam Zingam 233 days ago
frederick-vs-ja frederick-vs-ja requested a review from philnik777 philnik777 233 days ago
smallp-o-p
frederick-vs-ja
frederick-vs-ja commented on 2025-11-07
smallp-o-p Replace all usages of optional::value_type with _Tp, remove reference…
5cf46033
smallp-o-p Clean up deleted constructors signatures
3c2473d1
frederick-vs-ja
frederick-vs-ja requested changes on 2025-11-08
smallp-o-p Drive-by: Add a ranges::range<optional<T>> test for iterators
4f58bf29
smallp-o-p Add enable_borrowed_range<optional<T&>> and corresponding test
ba998d73
smallp-o-p
smallp-o-p Add to module inc
44d8d05f
frederick-vs-ja
frederick-vs-ja commented on 2025-11-09
smallp-o-p Make the borrowed_range test compile only
1cd8ebe3
frederick-vs-ja
frederick-vs-ja commented on 2025-11-10
smallp-o-p Remove std:: prefixes in iterator struct
d32557c8
smallp-o-p Simplify borrowed_range test
2d327fd5
smallp-o-p ditto
880558a9
smallp-o-p ADL lookup
995bb756
smallp-o-p ADL lookup
cddffc5e
frederick-vs-ja
frederick-vs-ja approved these changes on 2025-11-11
frederick-vs-ja
frederick-vs-ja frederick-vs-ja merged 389a23c5 into main 222 days ago
Zingam
Zingam
frederick-vs-ja
philnik777
philnik777
philnik777 commented on 2025-11-12
Zingam
H-G-Hristov
H-G-Hristov commented on 2025-11-30

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
libc++
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum