PR #169310 [CIR][X86] Implement lowering for sqrt builtins

Priyanshu3820 requested a review from

lanza 78 days ago

Priyanshu3820 requested a review from

bcardosolopes 78 days ago

Priyanshu3820 requested a review from

xlauko 78 days ago

Priyanshu3820 requested a review from

andykaylor 78 days ago

llvmbot added clang

llvmbot added ClangIR

Priyanshu3820 force pushed from be8cf21b to 990cbc45 78 days ago

Priyanshu3820 force pushed from 990cbc45 to a76b756f 78 days ago

andykaylor commented on 2025-11-24

Priyanshu3820 force pushed from a60dd645 to a4c8b5a5 76 days ago

Priyanshu3820 requested a review from

JDevlieghere 76 days ago

Priyanshu3820 requested a review from

cyndyishida 76 days ago

Priyanshu3820 requested a review from

rupprecht 76 days ago

Priyanshu3820 requested a review from

keith 76 days ago

Priyanshu3820 requested a review from

aaronmondal 76 days ago

Priyanshu3820 requested a review from

aaupov 76 days ago

Priyanshu3820 requested a review from

maksfb 76 days ago

Priyanshu3820 requested a review from

rafaelauler 76 days ago

Priyanshu3820 requested a review from

ayermolo 76 days ago

Priyanshu3820 requested a review from

yota9 76 days ago

Priyanshu3820 requested a review from

paschalis-mpeis 76 days ago

Priyanshu3820 requested a review from

yozhu 76 days ago

Priyanshu3820 requested a review from

Moxinilian 76 days ago

Priyanshu3820 requested a review from

makslevental 76 days ago

Priyanshu3820 requested a review from

rolfmorel 76 days ago

Priyanshu3820 requested a review from

ftynse 76 days ago

Priyanshu3820 requested a review from

stellaraccident 76 days ago

Priyanshu3820 requested a review from

grypp 76 days ago

Priyanshu3820 requested a review from

fabianmcg 76 days ago

Priyanshu3820 requested a review from

aartbik 76 days ago

Priyanshu3820 requested a review from

PeimingLiu 76 days ago

Priyanshu3820 requested a review from

yinying-lisa-li 76 days ago

Priyanshu3820 requested a review from

matthias-springer 76 days ago

Priyanshu3820 requested a review from

antiagainst 76 days ago

Priyanshu3820 requested a review from

kuhar 76 days ago

Priyanshu3820 requested a review from

nicolasvasilache 76 days ago

Priyanshu3820 requested a review from

hanhanW 76 days ago

Priyanshu3820 requested a review from

Groverkss 76 days ago

Priyanshu3820 requested a review from

Superty 76 days ago

Priyanshu3820 requested a review from

banach-space 76 days ago

Priyanshu3820 requested a review from

dcaballe 76 days ago

Priyanshu3820 requested a review from

rengolin 76 days ago

Priyanshu3820 requested a review from

silee2 76 days ago

Priyanshu3820 requested a review from

charithaintc 76 days ago

Priyanshu3820 requested a review from

Jianhui-Li 76 days ago

Priyanshu3820 requested a review from

krzysz00 76 days ago

Priyanshu3820 requested a review from

Endilll 76 days ago

Priyanshu3820 requested a review from

nikic 76 days ago

Priyanshu3820 requested a review 76 days ago

Priyanshu3820 closed this 76 days ago

Priyanshu3820 force pushed from a4c8b5a5 to 591c463e 76 days ago

Add CIR sqrt builtin support for X86

627bcb3b

Priyanshu3820 reopened this 76 days ago

Merge branch 'main' into cir-sqrtps-impl

d095f5a4

andykaylor removed review request 76 days ago

andykaylor removed review request from

nikic 76 days ago

andykaylor removed review request from

keith 76 days ago

andykaylor removed review request from

krzysz00 76 days ago

andykaylor removed review request from

antiagainst 76 days ago

andykaylor removed review request from

stellaraccident 76 days ago

andykaylor removed review request from

rupprecht 76 days ago

andykaylor removed review request from

JDevlieghere 76 days ago

andykaylor removed review request from

rolfmorel 76 days ago

andykaylor removed review request from

aaupov 76 days ago

andykaylor removed review request from

rengolin 76 days ago

andykaylor removed review request from

paschalis-mpeis 76 days ago

andykaylor removed review request from

ftynse 76 days ago

andykaylor removed review request from

matthias-springer 76 days ago

andykaylor removed review request from

banach-space 76 days ago

andykaylor removed review request from

grypp 76 days ago

andykaylor removed review request from

kuhar 76 days ago

andykaylor removed review request from

makslevental 76 days ago

andykaylor removed review request from

hanhanW 76 days ago

andykaylor removed review request from

fabianmcg 76 days ago

andykaylor removed review request from

maksfb 76 days ago

andykaylor removed review request from

rafaelauler 76 days ago

andykaylor removed review request from

Superty 76 days ago

andykaylor removed review request from

nicolasvasilache 76 days ago

andykaylor removed review request from

Endilll 76 days ago

andykaylor removed review request from

yota9 76 days ago

andykaylor removed review request from

dcaballe 76 days ago

andykaylor removed review request from

silee2 76 days ago

andykaylor removed review request from

cyndyishida 76 days ago

andykaylor removed review request from

Jianhui-Li 76 days ago

andykaylor removed review request from

aaronmondal 76 days ago

andykaylor removed review request from

Moxinilian 76 days ago

andykaylor removed review request from

PeimingLiu 76 days ago

andykaylor removed review request from

aartbik 76 days ago

andykaylor removed review request from

ayermolo 76 days ago

andykaylor removed review request from

Groverkss 76 days ago

andykaylor removed review request from

yozhu 76 days ago

andykaylor removed review request from

yinying-lisa-li 76 days ago

andykaylor removed review request from

charithaintc 76 days ago

andykaylor requested a review from

andykaylor 76 days ago

Merge branch 'main' into cir-sqrtps-impl

8c13c6ff

Merge branch 'main' into cir-sqrtps-impl

17a3e661

Merge branch 'main' into cir-sqrtps-impl

01bb815e

Implement sqrt builtins for all vector sizes

4a39fd71

Test file renamed

ef3fd971

Add sqrt changes patch

97056731

andykaylor commented on 2025-12-02

group with other floating point ops

21119e5a

Priyanshu3820 requested a review from

copilot-pull-request-reviewer 69 days ago

copilot-pull-request-reviewer commented on 2025-12-03

place the implementation with other floating point ops

90878ec8

Update clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp

3529f40b

Update clang/lib/CIR/CodeGen/CIRGenBuiltinX86.cpp

92d0ac3e

Update clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp

0385662d

update clang\lib\CIR\Lowering\DirectToLLVM\LowerToLLVM.cpp

ddcb7b84

update clang\lib\CIR\Lowering\DirectToLLVM\LowerToLLVM.cpp

1e846e74

Update clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.h

233efad6

Update clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp

9d940bc8

andykaylor commented on 2025-12-03

andykaylor commented on 2025-12-04

Remove BOM character

51bbccad

Merge branch 'cir-sqrtps-impl' of https://github.com/Priyanshu3820/ll…

f901f039

Apply suggestion from @Copilot

e5789b65

Apply suggestion from @andykaylor

8937b129

add description

8a02c504

Resolve merge conflict in LowerToLLVM.cpp

9923a624

Remove undefined sqrt builtin cases

82a93955

Remove unused getLLVMIntrinsicNameForType function

6bd32821

Removed braces

8232ce8a

Update clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp

bc8e4ccf

update clang\lib\CIR\Lowering\DirectToLLVM\LowerToLLVM.h

92847619

Update clang/test/CIR/CodeGen/X86/cir-sqrt-builtins.c

8647b5c7

Update test

4bac65a5

update clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp

b1ff2abd

andykaylor commented on 2025-12-04

Remove unused include

88430061

Move sqrt lowering with other floating point operations

ed824232

Merge branch 'main' into cir-sqrtps-impl

9e8bec2f

andykaylor commented on 2025-12-06

Remove BOM character

961c9f95

gergeebranch 'cir-sqrtps-impl' of https://github.com/Priyanshu3820/ll…

e5d1a6dd

Merge branch 'main' into cir-sqrtps-impl

44ddd799

Delete my-sqrt-changes.patch

4dd8aa07

Update errorNYI call

cc5ffa1e

Merge branch 'cir-sqrtps-impl' of https://github.com/Priyanshu3820/ll…

6d43c430

update clang\lib\CIR\Lowering\DirectToLLVM\LowerToLLVM.cpp

47f9b2ff

update clang/test/CIR/CodeGen/X86/cir-sqrt-builtins.c

15f1f4f1

Fix line endings in CIRGenBuiltinX86.cpp

b12779ab

andykaylor approved these changes on 2025-12-08

Fix formatting

996b7e7f

andykaylor merged 05b7720c into main 64 days ago

Priyanshu3820 deleted the cir-sqrtps-impl branch 34 days ago

llvm-project
[CIR][X86] Implement lowering for sqrt builtins
#169310

Merged

[CIR][X86] Implement lowering for sqrt builtins #169310

llvm-project [CIR][X86] Implement lowering for sqrt builtins #169310 Merged

[CIR][X86] Implement lowering for sqrt builtins #169310

llvm-project
[CIR][X86] Implement lowering for sqrt builtins
#169310

Merged