llvm-project
[clang-format] Ignore imports in comments for Java import sorting
#177326

Merged

[clang-format] Ignore imports in comments for Java import sorting #177326

owenca merged 27 commits into llvm:main from nataliakokoromyti:fix/java-import-comment-sorting-clean

llvmbot added clang-format

[clang-format] java import sorting should ignore imports in comments…

e281c437

nataliakokoromyti force pushed to e281c437 148 days ago

HazardyKnusperkeks commented on 2026-01-24

fix

bd865fcd

fix format

ee14636f

simplify regexpattern

d3ceb222

nataliakokoromyti requested a review from

HazardyKnusperkeks 144 days ago

owenca commented on 2026-02-02

rm JavaTypeDeclRegexPattern + handle trimmed.empty() at top

0446edfe

nataliakokoromyti requested a review from

owenca 137 days ago

owenca commented on 2026-02-07

fix regex

a775a5c4

fix formatting

ddca59c4

fix formatting

0d1ac13b

move trimmed.empty() to top

5f93956b

fix newline

8b4fbe90

nataliakokoromyti force pushed to 8b4fbe90 132 days ago

nataliakokoromyti requested a review from

owenca 132 days ago

owenca commented on 2026-02-08

owenca changed the title ~~[clang-format] java import sorting should ignore imports in comments and text blocks~~ [clang-format] Java import sorting should ignore imports in comments 131 days ago

owenca commented on 2026-02-08

owenca changed the title ~~[clang-format] Java import sorting should ignore imports in comments~~ [clang-format] ignore imports in comments for Java import sorting 131 days ago

owenca changed the title ~~[clang-format] ignore imports in comments for Java import sorting~~ [clang-format] Ignore imports in comments for Java import sorting 131 days ago

owenca commented on 2026-02-09

keep original comment

5c3449e9

set HasImport

cb0b54fd

rm SearchFrom + HasImport decl

6474762c

Update clang/lib/Format/Format.cpp

c98d19c8

Update clang/lib/Format/Format.cpp

c5692e56

Update clang/lib/Format/Format.cpp

483eb72f

Update clang/lib/Format/Format.cpp

22de9b38

Update clang/unittests/Format/SortImportsTestJava.cpp

68944684

Update clang/lib/Format/Format.cpp

23f28e75

rm SearchFrom usage everywhere

8b6dca09

small refactor

3ade17fb

add test that starts with package statement

d4ded313

nataliakokoromyti requested a review from

owenca 129 days ago

owenca commented on 2026-02-09

Update clang/unittests/Format/SortImportsTestJava.cpp

48e6e7ac

Update clang/unittests/Format/SortImportsTestJava.cpp

aa59de63

Update clang/lib/Format/Format.cpp

79bc74f0

owenca commented on 2026-03-14

Update clang/unittests/Format/SortImportsTestJava.cpp

ace16e01

owenca commented on 2026-03-14

Update clang/lib/Format/Format.cpp

ed1c91b6

owenca approved these changes on 2026-03-14

owenca merged 7894e636 into main 98 days ago

llvm deleted a comment from llvm-ci on 2026-03-14

Reviewers

owenca

HazardyKnusperkeks

Assignees

No one assigned

Labels

clang-format

Milestone

No milestone

llvm-project [clang-format] Ignore imports in comments for Java import sorting #177326 Merged

[clang-format] Ignore imports in comments for Java import sorting #177326

llvm-project
[clang-format] Ignore imports in comments for Java import sorting
#177326

Merged