PR #194984 [HLSL] Add matrix support to atan2

[HLSL] Add matrix support to atan2 #194984

joaosaffran merged 33 commits into llvm:main from joaosaffran:intrinsic/matrix-atan2

make it support float

babda1fb

adding matrix impl

43586d11

add tests and overloads

c4a5db93

make macro match other's

7ccd15fc

add more tests

fb3072ab

llvmorg-github-actions added clang

llvmorg-github-actions added backend:X86

llvmorg-github-actions added clang:frontend

llvmorg-github-actions added clang:headers

llvmorg-github-actions added HLSL

farzonl commented on 2026-04-30

adding sema tests

fe8cbb53

joaosaffran marked this pull request as draft 53 days ago

add matrix overloads

93a09ea2

joaosaffran requested a review from

farzonl 53 days ago

joaosaffran requested a review from

Icohedron 53 days ago

Icohedron commented on 2026-04-30

address comments

e0ba5039

joaosaffran requested a review from

Icohedron 53 days ago

joaosaffran marked this pull request as ready for review 53 days ago

joaosaffran marked this pull request as draft 53 days ago

Icohedron requested changes on 2026-04-30

add _mat tests

7b104990

Apply suggestion from @Icohedron

c328726c

clean up

9c0a5bce

Merge branch 'intrinsic/matrix-atan2' of github.com:joaosaffran/llvm-…

0261efe2

remove templates

a31a8fc0

clean up

43d7cbc0

Icohedron commented on 2026-05-01

fix tests

810ceebc

farzonl commented on 2026-05-04

fix legalization issue and improve tests

f075a16e

fixing test

70e57b6d

clean up

a095c36c

Apply suggestion from @farzonl

0637d22c

fix

fac7e0fc

joaosaffran requested a review from

farzonl 46 days ago

joaosaffran requested a review from

Icohedron 46 days ago

joaosaffran marked this pull request as ready for review 46 days ago

fix test.. hopefully

80852d3a

format

908bb19e

Icohedron approved these changes on 2026-05-08

Update clang/lib/Headers/hlsl/hlsl_compat_overloads.h

012dfee4

modify tests

042afd43

Merge branch 'intrinsic/matrix-atan2' of github.com:joaosaffran/llvm-…

7c87c49f

format

71e0c5aa

fix test

8b278f4c

address comment

9f917dba

Icohedron commented on 2026-05-08

fix x, y issue again

4b5e31d7

farzonl commented on 2026-05-09

Update clang/lib/Sema/SemaHLSL.cpp

f1b11707

address comments

fd2f857d

joaosaffran requested a review from

farzonl 42 days ago

farzonl commented on 2026-05-12

address comments

c8b14c76

fix test

e3a817fc

joaosaffran requested a review from

farzonl 41 days ago

farzonl approved these changes on 2026-05-13

joaosaffran merged befb2a60 into main 40 days ago

Reviewers

farzonl

Icohedron

Assignees

No one assigned

Labels

clang backend:X86 clang:frontend clang:headers HLSL

Milestone

No milestone

llvm-project [HLSL] Add matrix support to atan2 #194984 Merged

[HLSL] Add matrix support to atan2 #194984

llvm-project
[HLSL] Add matrix support to atan2
#194984

Merged