llvm-project
[CIR] Diagnose missing/bad `cir.triple` and `cir.opt_info` attributes in CIR tests instead of asserts/crashes
#230003
Merged
Merged
[CIR] Diagnose missing/bad `cir.triple` and `cir.opt_info` attributes in CIR tests instead of asserts/crashes #230003
koparasy
merged
33 commits into
llvm:main
from
ianayl:CIR/diagnose-bad-triple-optinfo
issue diagnostics on bad cir.triple instead of asserts
3d967e6f
issue diagnostics on malformed opt_info attrs
7148a335
patch up reading triples for cpuid op lowering
9a939caf
switch to unified helper for triple processing
fd373da1
I don't think there were any tangible benefits to using mlir::Failure…
3c65330e
copy cir-opt additions from #229575
72963ed0
clang-format
362290cc
draft up test cases
15677e38
Merge branch 'main' into CIR/diagnose-bad-triple-optinfo
81879032
ianayl
commented
on 2026-10-08
ianayl
commented
on 2026-10-08
ianayl
commented
on 2026-10-08
this test case is already covered in lowering-prepare-module-attrs.cir
aeaa75c8
update cir.cpuid op lowering diagnostics to provide more info
12140d97
ianayl
changed the title 
WIP: remove diagnostics from createLowerModule and move checking and …
9f08e15b
complete removing diags and moving validation to verifyOperationAttrs
7cac1228
Delete changes to EHABILowering; should be another PR
66d12d03
add tests for new CIR dialect verifier behavior
b273d9ff
add comment
58a6435d
delete a crap ton of test code; this feels good but I'll get rid of t…
6928e7ef
clang-format
2ac4c32b
throw missing triple diagnosis again after removing diagnostics from …
eb0f96ee
Patch up errors related to current EH ABI Lowering behavior
f61b88bd
clang-format
5ea820d6
be more assertive
31f259f5
delete cir-to-llvm-module-attrs test
ceb71339
clang-format
2471db08
fix code style
d2d42229
perpetual clang-format
64004de6
Test looser triple validation
579062c9
enforce that module attrs should be attached to a module
3cf376dd
andykaylor
commented
on 2026-10-19
Merge branch 'main' into CIR/diagnose-bad-triple-optinfo
7a58ffa5
Merge branch 'main' of https://github.com/llvm/llvm-project into CIR/…
ba248324
Merge branch 'main' of https://github.com/llvm/llvm-project into CIR/…
2d6224e3
andykaylor
approved these changes
on 2026-11-04
koparasy
approved these changes
on 2026-11-04
Merge branch 'main' of https://github.com/llvm/llvm-project into CIR/…
b4c420d5
Don't adjust targetInfo if targetInfo doesn't exist
0aacd5f5
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub