matrix-appservice-irc
Don't require commands be uppercase when using `!cmd`
#1823
Open
Don't require commands be uppercase when using `!cmd` #1823
spec/: fix tests to match previous changes
changelog
Seems reasonable aside from a lost test?
| 892 | 891 | `!cmd ${roomMapping.server} TOPIC ${newChannel} :some new fancy topic`, | |
| 893 | 892 | `!cmd ${roomMapping.server} PART ${newChannel}`, | |
| 894 | `!cmd ${roomMapping.server} STUPID COMMANDS`, | ||
| 895 | `!cmd rubbishserver SOME COMMAND`]; |
Half-Shot288 days agowe've lost the test for an invalid server here?
funderscore1288 days agoWith this change "rubbishserver" is now interpreted as a command rather than as a server.
Half-Shot288 days agoright...we still need to interpret servers here.
funderscore1288 days agoThey are interpreted correctly when valid, but rubbishserver matches the new regex.
Perhaps that could be replaced by rubbish^server! or something?
tadzik217 days agoOr we could have two servers configured to ensure that the first string needs to match a server.
I think it's okay to let this one slide though. We're not breaking anything anything except wrong usage of commands, and I don't think there's much of a risk of a server being called quit or something that could land a user in (minor) trouble.
oh and
| 887 | 887 | ||
| 888 | // 5 commands should be executed | ||
| 889 | // rubbishserver should not be accepted | ||
| 888 | // 4 commands should be executed | ||
| 890 | 889 | const commands = [ | |
| 891 | 890 | `!cmd ${roomMapping.server} JOIN ${newChannel}`, |
Half-Shot288 days agoWe still need to test lower case though?
tadzik217 days agoAdded in 1846095
Test lowercase command handling
Merge branch 'develop' into 1807-split/case-insensitive-admin-commands
Login to write a write a comment.
Split off from #1807, credit to @funderscore1