matrix-js-sdk
Process `m.room.encryption` events before emitting `RoomMember` events
#2910

Merged

Process `m.room.encryption` events before emitting `RoomMember` events #2910

richvdh merged 3 commits into develop from rav/fix_e2e_fail_in_new_room

richvdh2 years ago (edited 2 years ago)

Here's what your changelog entry will look like:

Process m.room.encryption events before emitting RoomMember events (#2910). Fixes element-hq/element-web#23819.

richvdh requested a review 2 years ago

richvdh requested a review from

justjanne 2 years ago

richvdh requested a review from

robintown 2 years ago

richvdh added T-Defect

Update tests

1f387ba6

Call `Store.storeRoom` earlier

9fddae69

richvdh force pushed from 368b30d6 to 4ebcb43c 2 years ago

Call onCryptoEvent before processing state events

6ec8461b

richvdh force pushed from 4ebcb43c to 6ec8461b 2 years ago

justjanne approved these changes on 2022-11-25

Conversation is marked as resolved

Show resolved

richvdh merged aaf3702c into develop 2 years ago

richvdh deleted the rav/fix_e2e_fail_in_new_room branch 2 years ago

richvdh restored the head branch 2 years ago

Reviewers

justjanne

robintown

Assignees

No one assigned

Labels

T-Defect

Milestone

No milestone

1389	1399
1390	1400	this.processEventsForNotifs(room, events);
1391	1401
1392		const processRoomEvent = async (e): Promise<void> => {
1393		client.emit(ClientEvent.Event, e);
1394		if (e.isState() && e.getType() == "m.room.encryption" && this.opts.crypto) {
1395		await this.opts.crypto.onCryptoEvent(e);
1396		}
1397		};
1398
1399		await utils.promiseMapSeries(stateEvents, processRoomEvent);
1400		await utils.promiseMapSeries(events, processRoomEvent);
1401		ephemeralEvents.forEach(function(e) {
1402		client.emit(ClientEvent.Event, e);
1403		});
1404		accountDataEvents.forEach(function(e) {
1405		client.emit(ClientEvent.Event, e);
1406		});
	1402	const emitEvent = (e: MatrixEvent): boolean => client.emit(ClientEvent.Event, e);

	const emitEvent = (e: MatrixEvent): boolean => client.emit(ClientEvent.Event, e);
	const emitEvent = (e: MatrixEvent): void => client.emit(ClientEvent.Event, e);