matrix-js-sdk
Improve hasUserReadEvent and getUserReadUpTo realibility with threads
#3031
Merged
Go
Login via GitHub
Home
Pricing
FAQ
Install
Login
via GitHub
Overview
Commits
29
Changes
View On
GitHub
Improve hasUserReadEvent and getUserReadUpTo realibility with threads
#3031
germain-gg
merged 29 commits into
develop
from
gsouquet/better-getreadupto
Add failing test scenario when multiple receipts are in the same event
d1db4dba
Fix cached read receipts
03968c32
Improve hasUserReadEvent and getUserReadUpTo realibility with threads
a776ff8b
germain-gg
added
T-Enhancement
clokep
commented on 2023-01-05
Reword code comments and improve readibility
23cd6208
Optimise code paths
1f3760ff
fix getEventReadUpTo logic with unthreaded receipts
be7fb616
Re-introduce optional chaining
0d4da281
fixes
1ccf9544
mend
c24f027d
Add tests for getEventReadUpTo and hasUserReadEvent
435f4857
germain-gg
marked this pull request as ready for review
2 years ago
germain-gg
requested a review
2 years ago
germain-gg
removed review request
2 years ago
germain-gg
requested a review
from
richvdh
2 years ago
germain-gg
requested a review
from
kerryarchibald
2 years ago
germain-gg
changed the base branch from
gsouquet/fix-cached-rr
to
develop
2 years ago
germain-gg
marked this pull request as draft
2 years ago
germain-gg
removed review request
from
richvdh
2 years ago
germain-gg
removed review request
from
kerryarchibald
2 years ago
germain-gg
force pushed
from
cf86e721
to
1779fbb5
2 years ago
germain-gg
force pushed
from
1779fbb5
to
435f4857
2 years ago
Merge branch 'develop' into gsouquet/better-getreadupto
3fe9d8a8
germain-gg
marked this pull request as ready for review
2 years ago
germain-gg
requested a review
from
richvdh
2 years ago
germain-gg
requested a review
from
justjanne
2 years ago
germain-gg
requested a review
from
kerryarchibald
2 years ago
richvdh
requested changes on 2023-01-06
Reword code comments and improve readibility
2f8328d3
Add comments to methods
e6348079
Make properties private and provide accessors
2d147d43
Remove unwanted change
c9827deb
Improve thread spec
d1ab2def
Explain the unthreaded receipt logic in comments
02f5a6c4
germain-gg
requested a review
from
richvdh
2 years ago
Merge branch 'develop' into gsouquet/better-getreadupto
420d0c34
richvdh
commented on 2023-01-09
richvdh
requested changes on 2023-01-09
Apply comments readibility suggestions
feb8f5ee
Clarify code comments based on PR feedback
5c5cbbf3
Remove unneeded nullish coalescing check
0ee16d39
Merge branch 'develop' into gsouquet/better-getreadupto
889c0b48
germain-gg
requested a review
from
richvdh
2 years ago
richvdh
requested changes on 2023-01-10
Merge branch 'develop' into gsouquet/better-getreadupto
83e0b712
Improve comments wording
253427d1
Clarify comments
4efb717e
germain-gg
requested a review
from
richvdh
2 years ago
fix tests
d2935d82
lint fix
1d889103
richvdh
commented on 2023-01-11
richvdh
approved these changes on 2023-01-11
Final comment wording updates
dae36b71
Merge branch 'develop' into gsouquet/better-getreadupto
64ab5a0b
germain-gg
merged
8e29f8ea
into develop
2 years ago
germain-gg
deleted the gsouquet/better-getreadupto branch
2 years ago
Login to write a write a comment.
Login via GitHub
Reviewers
richvdh
clokep
justjanne
kerryarchibald
Assignees
No one assigned
Labels
T-Enhancement
Milestone
No milestone
Login to write a write a comment.
Login via GitHub