matrix-react-sdk
Editor caret improvements
#3126
Merged

Editor caret improvements #3126

bwindels merged 9 commits into develop from bwindels/caret-refactoring
bwindels
bwindels insert "caret nodes" where pills don't have an adjacent text node
75fc7697
bwindels also process first part when processing empty and mergeable parts
607fc328
bwindels use caret nodes in caret positioning code, to move caret out of pills
a2296419
bwindels remove special casing for moving caret after newline and pills
f0271b59
bwindels insert manually, as insertHTML command moves caret inconsistently
b16bc017
bwindels put zero-width spaces in caret nodes so chrome doesn't ignore them
366a4aa3
bwindels bwindels marked this pull request as ready for review 6 years ago
bwindels bwindels requested a review 6 years ago
bwindels use BOM marker instead of ZWS
c5c987f6
bwindels caretNode is a better className
da766b8c
jryans
jryans approved these changes on 2019-06-21
bwindels clarify why use a BOM marker for the caret nodes
c443dd7a
bwindels bwindels merged 1c7af38d into develop 6 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
Milestone