matrix-react-sdk
Fix `getRelationsForEvent` under TypeScript `strict` mode
#9558
Merged
Overview
Commits
31
Changes
View On GitHub

Fix `getRelationsForEvent` under TypeScript `strict` mode #9558

turt2live merged 31 commits into develop from madlittlemods/strict-getRelationsForEvent
MadLittleMods
MadLittleMods Fix getRelationsForEvent tsc strictness
b291130c
MadLittleMods MadLittleMods added T-Task
MadLittleMods Use shared type for GetRelationsForEvent
331be20c
MadLittleMods
MadLittleMods commented on 2022-11-08
MadLittleMods Fix lint
639ae6fa
MadLittleMods Add alternative type
095347e1
MadLittleMods getRelationsForEvent is not required
6db8927c
MadLittleMods Relations are optional
1eabf6af
MadLittleMods Reactions are optional
3060bba5
MadLittleMods We expect relations in these tests
bc788c07
MadLittleMods
MadLittleMods commented on 2022-11-08
MadLittleMods Add more protection if the eventID is not defined
f42971ba
MadLittleMods Allow null too
6aec3efb
MadLittleMods Better test typing
0f80d5a4
MadLittleMods
MadLittleMods commented on 2022-11-08
MadLittleMods
MadLittleMods commented on 2022-11-08
MadLittleMods MadLittleMods changed the title Fix `getRelationsForEvent` tsc strictness Fix `getRelationsForEvent` under TypeScript `strict` mode 3 years ago
MadLittleMods User ID is not necessary unless something is selected
bab05e2c
MadLittleMods It's okay to [].includes(null)
a5a61d20
MadLittleMods Null is as good as undefined here
ae6dddc7
MadLittleMods Null or undefined is good here
a51fb2c1
MadLittleMods We have some expectations for the tests
0cef622e
MadLittleMods The room and user can be undefined too
6caefb01
MadLittleMods Protec
eb30722a
MadLittleMods Reactions are optional
7aaf1076
MadLittleMods Try match signatures
75582e71
MadLittleMods Null or undefined
382c3800
MadLittleMods More null or undefined
07089e75
MadLittleMods Protec
847132e9
MadLittleMods
MadLittleMods commented on 2022-11-09
MadLittleMods
MadLittleMods commented on 2022-11-09
MadLittleMods MadLittleMods marked this pull request as ready for review 3 years ago
MadLittleMods MadLittleMods requested a review 3 years ago
MadLittleMods MadLittleMods requested a review from t3chguy t3chguy 3 years ago
MadLittleMods MadLittleMods requested a review from weeman1337 weeman1337 3 years ago
weeman1337
weeman1337 approved these changes on 2022-11-09
MadLittleMods
MadLittleMods commented on 2022-11-09
MadLittleMods Fix typo (wrong variable)
cd98cef6
MadLittleMods Remove optional params
a9094561
MadLittleMods Fix up last maaaaybe relevant lint
25d0e362
MadLittleMods
MadLittleMods commented on 2022-11-10
MadLittleMods Merge branch 'develop' into madlittlemods/strict-getRelationsForEvent
5b762181
MadLittleMods MadLittleMods removed review request from t3chguy t3chguy 3 years ago
MadLittleMods MadLittleMods requested a review from t3chguy t3chguy 3 years ago
t3chguy Merge branch 'develop' into madlittlemods/strict-getRelationsForEvent
2467df2c
MadLittleMods Merge branch 'develop' into madlittlemods/strict-getRelationsForEvent
8bf3d645
MadLittleMods Merge branch 'madlittlemods/strict-getRelationsForEvent' of github.co…
0a18bba6
MadLittleMods Merge branch 'develop' into madlittlemods/strict-getRelationsForEvent
d0e72585
MadLittleMods MadLittleMods removed review request from t3chguy t3chguy 3 years ago
MadLittleMods MadLittleMods requested a review from turt2live turt2live 3 years ago
turt2live
turt2live approved these changes on 2022-11-22
turt2live turt2live merged 2393510a into develop 3 years ago
turt2live turt2live deleted the madlittlemods/strict-getRelationsForEvent branch 3 years ago
MadLittleMods

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
T-Task
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum