All modified and coverable lines are covered by tests ✅
Project coverage is 85.02%. Comparing base (
a8a83c3
) to head (01ed8ad
).
Report is 1 commits behind head on main.
@@ Coverage Diff @@
## main #4268 +/- ##
==========================================
- Coverage 85.03% 85.02% -0.01%
==========================================
Files 274 274
Lines 30028 30039 +11
==========================================
+ Hits 25533 25541 +8
- Misses 4495 4498 +3
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
LGTM!
1137 | 1180 | thumbnail: Option<(FinishUploadThumbnailInfo, MediaRequestParameters, Mime)>, | |
1138 | 1181 | ) -> Result<(), RoomSendQueueStorageError> { | |
1139 | // Keep the lock until we're done touching the storage. | ||
1140 | // TODO refactor to make the relationship between being_sent and the store more |
👍
Login to write a write a comment.
There was an implicit relationship that the
being_sent
lock needed to be taken in order to do non-atomic state store operations. With the change from this commit, the relationship is now more explicit: to get a handle to the state store, or being_sent, you have to obtain aStoreLockGuard
by locking against the store itself. TheWeakClient
isn't stored in the QueueStorage data structure itself, so it's the only way to get adyn StateStore
from theQueueStorage
.