PR #1439 Correctly provide swagger UI as a build on Circle

Correctly provide swagger UI as a build on Circle #1439

turt2live merged 1 commit into matrix-org:master from Cadair:swagger_circle

Cadair6 years ago

This clones the swagger UI and then outputs a redirected URL so swagger works at the end :)

turt2live commented on 2018-07-20

turt2live6 years ago

also sign off please :)

.circleci/config.yml

	20		mkdir -p api/client-server/json
	21		cp scripts/swagger/api-docs.json api/client-server/json/
	22		wget https://raw.githubusercontent.com/matrix-org/matrix.org/master/content/swagger.css -O api/client-server/swagger.css
	23		patch api/client-server/index.html scripts/swagger-ui.patch

turt2live6 years ago

I'm wondering if we should also wget the swagger patch to avoid having to maintain it twice.

Cadair6 years ago

I had to change it. Could probably merge the changes into the matrix.org repo though.

turt2live6 years ago

+1 to that :)

turt2live commented on 2018-07-20

.circleci/config.yml

	20		mkdir -p api/client-server/json
	21		cp scripts/swagger/api-docs.json api/client-server/json/
	22		wget https://raw.githubusercontent.com/matrix-org/matrix.org/master/content/swagger.css -O api/client-server/swagger.css
	23		wget https://raw.githubusercontent.com/matrix-org/matrix.org/master/scripts/swagger-ui.patch

turt2live6 years ago

I think you'll need to -O scripts/swagger-ui.patch on this

Cadair6 years ago

I changed the line below to read the patch file from the cwd.

Cadair force pushed from fa229fa5 to ea815046 6 years ago

Clone and configure the swagger UI as a circle CI artifact

59bdcb56

Cadair force pushed from ea815046 to 59bdcb56 6 years ago

turt2live approved these changes on 2018-07-20

turt2live6 years ago

LGTM

turt2live merged 42447daf into master 6 years ago

Cadair deleted the swagger_circle branch 6 years ago

Reviewers

turt2live

Assignees

No one assigned

Labels

None yet

Milestone

No milestone