PR #19693 Follow up fix for Gelu impl

Follow up fix for Gelu impl #19693

pengwa merged 5 commits into main from pengwa/gelu_fix

fix macros. move ROCM Gelu tanh path to use ROCM FastGelu impl

72f48569

minor

01107eec

pengwa requested a review from

tianleiwu 1 year ago

pengwa requested a review from

mindest 1 year ago

tianleiwu commented on 2024-02-28

mindest commented on 2024-02-29

fix

81fc761f

Update gelu.cc

f9816fb0

fallback gelu tanh path to use the cuda fast gelu impl, due to core/p…

c2bf3b9f

tianleiwu approved these changes on 2024-02-29

pengwa merged acbfc29f into main 1 year ago

pengwa deleted the pengwa/gelu_fix branch 1 year ago

Reviewers

tianleiwu

mindest

Assignees

No one assigned

Labels

None yet

Milestone

No milestone