onnxruntime
Prevent double-free in OrtModelEditorApi ownership transfer
#28123
Merged
Merged
Prevent double-free in OrtModelEditorApi ownership transfer #28123
yuslepukhin
merged
15 commits into
main
from
vraspar/fix-model-editor-double-free
Prevent double-free in OrtModelEditorApi ownership transfer
c3994128
Fix exception safety: track initializer pointer before ownership tran…
7de13ae7
copilot-pull-request-reviewer
commented
on 2026-04-22
Exception-safe ownership transfer in AddInitializerToGraph and AddNod…
c3c93d4e
Add null checks for ort_graph/arrays and owned_ guard for ModelEditor…
03e756a7
yuslepukhin
requested changes
on 2026-04-28
Guard Release functions against double-free after ownership transfer
004550f4
Copy OrtValue in AddInitializerToGraph instead of taking ownership
a7ecbecb
Reserve vector capacity before ownership-transfer loops in SetGraphIn…
391f2c1b
Use geometric reserve growth in AddNodeToGraph and fix _Inout_ to _In…
868456f0
Simplify C++ wrapper comment for AddInitializer
6320ff5c
Remove misleading refcounting detail from AddInitializerToGraph doc
b4f0b422
yuslepukhin
commented
on 2026-05-02
yuslepukhin
commented
on 2026-05-02
yuslepukhin
commented
on 2026-05-02
yuslepukhin
commented
on 2026-05-02
yuslepukhin
commented
on 2026-05-02
yuslepukhin
commented
on 2026-05-02
Address reviewer feedback: const OrtValue, store by value, rename ten…
4b1dd054
Split release-after-ownership tests into debug (ASSERT_DEATH) and rel…
5471e472
yuslepukhin
dismissed these changes
on 2026-05-04
Add doxygen cross-references for OrtModelEditorApi doc comments
983161f6
yuslepukhin
dismissed these changes
on 2026-05-04
Guard release-after-ownership tests with NDEBUG and clean up comments
37a452fa
yuslepukhin
commented
on 2026-05-05
Swap reserve/clear order to avoid relocating elements before clear
389e7489
yuslepukhin
approved these changes
on 2026-05-06
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub