onnxruntime
Validate sparse tensor external file paths
#28408
Merged

Validate sparse tensor external file paths #28408

adrianlizarraga
adrianlizarraga First draft: validate sparse tensor external files (values and indices)
084e3088
adrianlizarraga adrianlizarraga requested a review from copilot-pull-request-reviewer copilot-pull-request-reviewer 36 days ago
copilot-pull-request-reviewer
copilot-pull-request-reviewer commented on 2026-05-08
adrianlizarraga Rename function
ed72a193
adrianlizarraga Update func comment
157b65f6
adrianlizarraga adrianlizarraga requested a review from copilot-pull-request-reviewer copilot-pull-request-reviewer 35 days ago
copilot-pull-request-reviewer
copilot-pull-request-reviewer commented on 2026-05-08
adrianlizarraga Address review comments
b0cc4575
adrianlizarraga adrianlizarraga requested a review from copilot-pull-request-reviewer copilot-pull-request-reviewer 35 days ago
copilot-pull-request-reviewer
copilot-pull-request-reviewer commented on 2026-05-08
adrianlizarraga adrianlizarraga marked this pull request as ready for review 35 days ago
yuslepukhin
yuslepukhin
yuslepukhin commented on 2026-05-14
adrianlizarraga Fix sparse tensor indices size check for external data
de4828f6
adrianlizarraga Add positive tests for sparse tensors with external data
917987f3
adrianlizarraga Add path validation tests (reject absolute paths) for sparse tensors …
4785b3ee
adrianlizarraga Move check outside to account for nnz=0
9c4e1caf
adrianlizarraga Merge branch 'main' into adrianl/SparseTensor_ExternalDataFilePathVal…
f3a5c52c
adrianlizarraga adrianlizarraga requested a review from copilot-pull-request-reviewer copilot-pull-request-reviewer 28 days ago
copilot-pull-request-reviewer
copilot-pull-request-reviewer commented on 2026-05-15
adrianlizarraga Address copilot review comments: move validation checks earlier to ca…
be9a8c95
adrianlizarraga adrianlizarraga requested a review from copilot-pull-request-reviewer copilot-pull-request-reviewer 28 days ago
copilot-pull-request-reviewer
copilot-pull-request-reviewer commented on 2026-05-15
adrianlizarraga Add tets for zero nnz case
671f81c2
adrianlizarraga
adrianlizarraga adrianlizarraga requested a review from yuslepukhin yuslepukhin 28 days ago
adrianlizarraga adrianlizarraga requested a review from copilot-pull-request-reviewer copilot-pull-request-reviewer 28 days ago
copilot-pull-request-reviewer
copilot-pull-request-reviewer commented on 2026-05-15
adrianlizarraga Fix HasExternalDataInFile bypass and strengthen zero-element tests
dae7767a
adrianlizarraga Add comment about why not using utils
7cb85e31
adrianlizarraga adrianlizarraga requested a review from copilot-pull-request-reviewer copilot-pull-request-reviewer 28 days ago
copilot-pull-request-reviewer
copilot-pull-request-reviewer commented on 2026-05-15
adrianlizarraga Restore raw_data().size() check for non-external indices
79dae211
adrianlizarraga adrianlizarraga requested a review from copilot-pull-request-reviewer copilot-pull-request-reviewer 28 days ago
copilot-pull-request-reviewer
copilot-pull-request-reviewer commented on 2026-05-15
yuslepukhin
yuslepukhin approved these changes on 2026-05-18
adrianlizarraga adrianlizarraga merged 6a8f021b into main 24 days ago
adrianlizarraga adrianlizarraga deleted the adrianl/SparseTensor_ExternalDataFilePathValidation branch 24 days ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone