onnxruntime
Clarify and improve ownership semantics Model Editor C/C++ API
#28800
Merged
Go
Login via GitHub
Home
Pricing
FAQ
Install
Login
via GitHub
Overview
Commits
18
Changes
View On
GitHub
Clarify and improve ownership semantics Model Editor C/C++ API
#28800
yuslepukhin
merged 18 commits into
main
from
yuslepukhin/revert_model_editor_change
Revert "Prevent double-free in OrtModelEditorApi ownership transfer (…
c1c4dfac
Reject duplicate raw-pointer ownership transfer in OrtModelEditorApi
3b2504e3
Add regression tests for duplicate raw-pointer guards in OrtModelEdit…
1c8f985c
yuslepukhin
requested a review
from
skottmckay
125 days ago
yuslepukhin
requested a review
from
copilot-pull-request-reviewer
125 days ago
copilot-pull-request-reviewer
commented on 2026-06-05
Address review feedback: validation, duplicate-name, doc clarifications
e16bfb54
Make OrtModelEditorApi take-ownership APIs strongly exception-safe
e7dc1fe4
Reword C API docs as atomicity; document and fix C++ exception safety
1a2a90cc
Use kSmallTensorExternalDataThreshold for external-initializer size c…
17d69cb3
Combine duplicate-name validation with try_emplace in AddInitializerT…
d01489c9
Clarify size-guard rationale in AddInitializerToGraph(data_is_externa…
8113a5be
Add tests for new ModelEditor C-API validation paths
63548e47
Fix build error
3c0cf048
yuslepukhin
requested a review
from
copilot-pull-request-reviewer
124 days ago
copilot-pull-request-reviewer
commented on 2026-06-05
yuslepukhin
requested a review
from
copilot-pull-request-reviewer
124 days ago
copilot-pull-request-reviewer
commented on 2026-06-05
Address review comments
28fc8f38
yuslepukhin
requested a review
from
copilot-pull-request-reviewer
124 days ago
yuslepukhin
commented on 2026-06-05
yuslepukhin
commented on 2026-06-05
yuslepukhin
commented on 2026-06-05
copilot-pull-request-reviewer
commented on 2026-06-05
Address review comments
2dbf22ea
Address build failure
036dab71
yuslepukhin
requested a review
from
copilot-pull-request-reviewer
124 days ago
copilot-pull-request-reviewer
commented on 2026-06-05
Make AddInitializerToGraph small-external error message actionable
ac1943a2
Fix MSVC build: use const std::vector<int64_t>& for MakeCpuFloatTenso…
44bb34f1
yuslepukhin
added
release:1.27.0
tianleiwu
commented on 2026-06-06
sanaa-hamel-microsoft
commented on 2026-06-06
sanaa-hamel-microsoft
requested changes on 2026-06-08
Address review comments
7692431b
yuslepukhin
requested a review
from
copilot-pull-request-reviewer
121 days ago
yuslepukhin
requested a review
from
sanaa-hamel-microsoft
121 days ago
copilot-pull-request-reviewer
commented on 2026-06-08
sanaa-hamel-microsoft
dismissed these changes on 2026-06-08
Address review comments: fix doc, reorder checks, move node->id after…
bea8b9c4
yuslepukhin
dismissed their stale review via
bea8b9c4
121 days ago
sanaa-hamel-microsoft
approved these changes on 2026-06-08
yuslepukhin
merged
dadd2d03
into main
121 days ago
yuslepukhin
deleted the yuslepukhin/revert_model_editor_change branch
121 days ago
Login to write a write a comment.
Login via GitHub
Reviewers
sanaa-hamel-microsoft
adrastogi
tianleiwu
copilot-pull-request-reviewer
skottmckay
Assignees
No one assigned
Labels
release:1.27.0
Milestone
No milestone
Login to write a write a comment.
Login via GitHub