onnxruntime
Support negative indices and fix bound checking in symbolic shape inference for Slice
#7401

Merged

Support negative indices and fix bound checking in symbolic shape inference for Slice #7401

ke1337 merged 11 commits into master from ryoto/dim-positivity-fix-for-slice

Use positivity everywhere; handle negative index in Slice

f52f4e5c

ryotatomioka requested a review 4 years ago

limit positivity to inputs

bdec7647

make handle_negative_index private

7ec1b5b9

strengthen sympy comparison

21888efe

further strengthen compariso

daa2c07a

ke1337 commented on 2021-04-26

ke1337 dismissed these changes on 2021-04-28

ke1337 commented on 2021-04-28

Add flip test

b2031fe8

Fall through if -int_max in handle_negative_index()

b06440e5

minor fix for infer_Concat to include initializers

5d09031e

Add more tests

0f082fa9

use simplify

6dd8c8ba

more tests

a7dceea6

ryotatomioka dismissed their stale review via 0f082fa9 4 years ago

ryotatomioka commented on 2021-05-03

ke1337 approved these changes on 2021-05-03

ke1337 merged d1cb8c9d into master 4 years ago

ke1337 deleted the ryoto/dim-positivity-fix-for-slice branch 4 years ago

Reviewers

ke1337

Assignees

No one assigned

Labels

None yet

Milestone

No milestone