PR #9492 Fix bug in Slice helper when dim value is zero

Fix bug in Slice helper when dim value is zero #9492

skottmckay merged 3 commits into master from skottmckay/bugfix/HandleDimValueOfZeroInSlice

Don't clamp if dim_value is zero as that will set `step` to an invali…

e093966d

skottmckay requested a review from

guoyu-wang 4 years ago

guoyu-wang dismissed these changes on 2021-10-22

Address PR comment

7e1376e0

Merge remote-tracking branch 'origin/master' into skottmckay/bugfix/H…

ccb58d88

skottmckay dismissed their stale review via ccb58d88 4 years ago

guoyu-wang approved these changes on 2021-10-25

skottmckay merged 39d1b9e1 into master 4 years ago

skottmckay deleted the skottmckay/bugfix/HandleDimValueOfZeroInSlice branch 4 years ago

Reviewers

guoyu-wang

Assignees

No one assigned

Labels

None yet

Milestone

No milestone