PR #737 Fix pairwise attention comparison in test

Fix pairwise attention comparison in test #737

sashaDoubov merged 4 commits into mosaicml:main from sashaDoubov:sasha/fix-attn-test

fix attn impl not being set

60cdf36a

sashaDoubov changed the title ~~fix attn impl not being set~~ Fix pairwise attention comparison in test 2 years ago

sashaDoubov marked this pull request as draft 2 years ago

change d_model and increase tolerance

f603b469

sashaDoubov marked this pull request as ready for review 2 years ago

sashaDoubov requested a review from

vchiley 2 years ago

sashaDoubov requested a review from

dakinggg 2 years ago

sashaDoubov requested a review from

ShashankMosaicML 2 years ago

dakinggg approved these changes on 2023-11-15

add special case

51a43b1b

ShashankMosaicML approved these changes on 2023-11-15

ShashankMosaicML commented on 2023-11-15

undo typo

d9159346

sashaDoubov merged f114dad5 into main 2 years ago

Reviewers

ShashankMosaicML

dakinggg

vchiley

Assignees

No one assigned

Labels

None yet

Milestone

No milestone