v8: remove --harmony-top-level-await #40226
Should we block this from being backported to any branches?
https://ci.nodejs.org/job/node-test-pull-request/40092/ is fully passing.
I think we should also remove test/message/esm_display_syntax_error.mjs, test/message/esm_display_syntax_error.out, and test/parallel/test-no-harmony-top-level-await.mjs.
I think we should also remove
test/message/esm_display_syntax_error.mjs,test/message/esm_display_syntax_error.out, andtest/parallel/test-no-harmony-top-level-await.mjs.
Yes, I think we can remove these tests.
v8: remove --harmony-top-level-await
@GeoffreyBooth removing the flag from core would be a semver-major change since it is currently a no-op and removing it would cause node to throw with a bad option error
Landed in 481c160...02de402
Added dont-land-on-v16.x label and waiting for #37468 before ready for v16.x.
@danielleadams Wouldn't backport-blocked-v16.x label be more suited for the this PR? I think we do want this to land on v16.x.
Login to write a write a comment.
Removes the
--harmony-top-level-awaitflag now that top-level await is enabled by default in V8.Cleans up a TODO from @MylesBorins 😉