nvda
Fix-up of PR 12943 - Avoid os.path.commonPath` when comparing paths of the binaries as it does not work for files on different drives
#13009

Merged

Fix-up of PR 12943 - Avoid os.path.commonPath` when comparing paths of the binaries as it does not work for files on different drives #13009

seanbudd merged 1 commit into nvaccess:master from lukaszgo1:I13008

Use `casefold` when comparing file paths as `os.path.commonPath` fail…

71867c47

lukaszgo1 force pushed from dc0fc0f4 to 71867c47 4 years ago

lukaszgo1 marked this pull request as ready for review 4 years ago

lukaszgo1 requested a review 4 years ago

lukaszgo1 requested a review from

michaelDCurran 4 years ago

seanbudd approved these changes on 2021-10-31

seanbudd changed the title ~~Fix-up of PR 12943 - Avoid os.path.commonPath` when comparing path's of the binaries as it does not work for files on different drives~~ Fix-up of PR 12943 - Avoid os.path.commonPath` when comparing paths of the binaries as it does not work for files on different drives 4 years ago

seanbudd merged 205df17a into master 4 years ago

nvaccessAuto added this to the 2022.1 milestone 4 years ago

lukaszgo1 deleted the I13008 branch 4 years ago

Reviewers

seanbudd

michaelDCurran

Assignees

No one assigned

Labels

None yet

Milestone

2022.1

nvda Fix-up of PR 12943 - Avoid os.path.commonPath` when comparing paths of the binaries as it does not work for files on different drives #13009 Merged

Fix-up of PR 12943 - Avoid os.path.commonPath` when comparing paths of the binaries as it does not work for files on different drives #13009

nvda
Fix-up of PR 12943 - Avoid os.path.commonPath` when comparing paths of the binaries as it does not work for files on different drives
#13009

Merged