PR #14233 Make config options and GUI settings match

Make config options and GUI settings match #14233

feerrenrut merged 28 commits into nvaccess:master from CyrilleB79:comboboxAndConfigMatch

The following option with a combo-box in NVDA settings window is now …

39bd3dc7

Single config option matching show message option in braille settings.

1c20051a

Single config option matching Cell borders option in doc formatting s…

a146bd59

Single config option matching Tether to option in Braille settings

0da6472b

CyrilleB79 force pushed from 2be0b47a to 0da6472b 3 years ago

CyrilleB79 marked this pull request as ready for review 3 years ago

CyrilleB79 requested a review 3 years ago

CyrilleB79 requested a review from

seanbudd 3 years ago

seanbudd commented on 2022-10-17

seanbudd marked this pull request as draft 3 years ago

Apply suggestions from code review

019d8f94

Remove unintended modification of sonic library.

e8cb906a

CyrilleB79 marked this pull request as ready for review 3 years ago

lukaszgo1 commented on 2022-10-17

seanbudd marked this pull request as draft 3 years ago

Update function description.

9a9aad57

Use enum instead of constants for TETHER_*

faf36b3c

CyrilleB79 marked this pull request as ready for review 3 years ago

seanbudd requested a review from

feerrenrut 3 years ago

seanbudd requested changes on 2022-10-19

Fix range issue in config spec.

4695509b

Modify formatting as per review comment.

f7c27a22

Apply suggestions from code review

d4ae1e30

Modify type hints.

8b3ce27d

seanbudd marked this pull request as draft 3 years ago

Merge branch 'master' into comboboxAndConfigMatch

8aed5785

Fix system tests

983a86ec

CyrilleB79 force pushed from fc207525 to 983a86ec 3 years ago

Fix bug found while developping unit tests.

a6369457

Unit tests for _upgradeConfigFrom_8_to_9_showMessages

5b3b4fc6

Merge branch 'master' into comboboxAndConfigMatch

c1259b4f

Some more unit tests (WIP)

376376f5

All normal unit tests (for default profile) implemented.

c4e6cd6e

Fix bug after unit tests implementation.

32351b5c

Add one more corner case unit test.

25caec0e

CyrilleB79 removed review request from

feerrenrut 3 years ago

CyrilleB79 requested a review from

seanbudd 3 years ago

CyrilleB79 marked this pull request as ready for review 3 years ago

seanbudd approved these changes on 2022-11-13

seanbudd requested a review from

feerrenrut 3 years ago

Add type hints.

fae05426

feerrenrut requested changes on 2022-11-15

Use enum instead of hard-coded values.

559460c8

feerrenrut approved these changes on 2022-11-21

Address review comments.

9edee7e5

Linting

6fb889e9

feerrenrut approved these changes on 2022-11-22

Merge branch 'origin/master'

037f7808

update changes file for PR #14233

4618d68d

CyrilleB79 commented on 2022-11-22

fixup changes entry

a2607ca6

feerrenrut merged 3200385e into master 3 years ago

nvaccessAuto added this to the 2023.1 milestone 3 years ago

CyrilleB79 deleted the comboboxAndConfigMatch branch 3 years ago

Reviewers

seanbudd

feerrenrut

lukaszgo1

Assignees

No one assigned

Labels

None yet

Milestone

2023.1

nvda Make config options and GUI settings match #14233 Merged

Make config options and GUI settings match #14233

nvda
Make config options and GUI settings match
#14233

Merged