nvda
Add com port option in Braille Display Select Dialog and fix Serial Connection error
#16340

Merged

Add com port option in Braille Display Select Dialog and fix Serial Connection error #16340

seanbudd merged 79 commits into nvaccess:master from FIX_HIMS_BRAILLE_OPTION

fix incorrectly assigned combination keys.

0628b0b4

Update user_docs/en/changes.t2t

f4f560f7

Update user_docs/en/changes.t2t

13d6f5b2

Update user_docs/en/userGuide.t2t

14166488

update userGuide and changes.t2t

b80c46b1

Update user_docs/en/changes.t2t

75824815

Apply suggestions from code review

0a35e9ca

Merge branch 'master' of https://github.com/nvaccess/nvda

633e9006

Merge branch 'master' of https://github.com/EdKweon/nvda

5f42d7a9

Merge branch 'master' of https://github.com/nvaccess/nvda

d5ebb317

Merge branch 'master' of https://github.com/nvaccess/nvda

5ae0e35c

Merge branch 'master' of https://github.com/nvaccess/nvda

1dade921

fix serial connection error

92f8d7e6

Merge branch 'nvaccess:master' into FIX_HIMS_BRAILLE_OPTION

d2cbe881

EdKweon requested a review 2 years ago

EdKweon requested a review from

michaelDCurran 2 years ago

LeonarddeR commented on 2024-03-28

delete unneccessary line

ab80c9ba

fix Lint error

fc444f74

seanbudd dismissed these changes on 2024-04-15

Apply suggestions from code review

f953b28a

seanbudd added conceptApproved

seanbudd dismissed their stale review 1 year ago

stale

seanbudd marked this pull request as draft 1 year ago

Merge branch 'master' of https://github.com/nvaccess/nvda into FIX_HI…

cd36c049

Merge branch 'FIX_HIMS_BRAILLE_OPTION' of https://github.com/EdKweon/…

05377c5c

Loew HID priority for specific devices

a8f360d9

fix lint error

536954e7

EdKweon marked this pull request as ready for review 1 year ago

seanbudd commented on 2024-05-06

seanbudd marked this pull request as draft 1 year ago

LeonarddeR requested changes on 2024-05-06

Update source/bdDetect.py

084ac4e3

Update source/bdDetect.py

ed3629a1

Update source/brailleDisplayDrivers/hims.py

0295ce86

split parameter

f8534ed9

Update source/bdDetect.py

69a6f246

Update source/bdDetect.py

6a3038be

update parameter docs

73f9f175

add return type

6c056915

Merge branch 'FIX_HIMS_BRAILLE_OPTION' of https://github.com/EdKweon/…

f8a1c1d4

change class name, add member variable type

5c379eb9

fix infinite iteration

5ea30315

rollback

7cf2b574

fix list growing error

8040fb72

LeonarddeR requested changes on 2024-05-10

rollback fallback

b475b6fc

delete empty line

1900c71a

rollback match order hims.py

e4241ad3

rollback match order hims.py v2

5b4c5b28

roll back fallback code

06502ce0

fix parameter type

12351bf4

EdKweon marked this pull request as ready for review 1 year ago

EdKweon marked this pull request as draft 1 year ago

resolve comment

11093525

add fallback

07d007aa

fix lint

b2d4714e

fix override function name

cf0ed605

fix lint

c4409ab4

fix settingsDialog portsList error

0c6eb299

EdKweon marked this pull request as ready for review 1 year ago

LeonarddeR requested changes on 2024-05-20

LeonarddeR commented on 2024-05-20

Update source/bdDetect.py

1e0985eb

Update source/bdDetect.py

26dc8ab9

Merge branch 'FIX_HIMS_BRAILLE_OPTION' of https://github.com/EdKweon/…

040493e8

rollback DeviceMatch class

3e378734

associate driver with fallback

4d91c25d

seanbudd marked this pull request as draft 1 year ago

add fallback in getDriversForconnectedUsbDevices

a0261421

fix variable name

088e436a

EdKweon marked this pull request as ready for review 1 year ago

LeonarddeR approved these changes on 2024-06-04

Update source/bdDetect.py

88260015

clear fallbackDevices in terminate function

95da774f

coderabbitai commented on 2024-06-06

Update source/bdDetect.py

ce39b8b3

LeonarddeR commented on 2024-06-06

Update source/bdDetect.py

a1587a91

split serial accumulate data

bfa7af96

EdKweon commented on 2024-06-07

seanbudd marked this pull request as draft 1 year ago

EdKweon marked this pull request as ready for review 1 year ago

seanbudd requested changes on 2024-06-11

seanbudd marked this pull request as draft 1 year ago

seanbudd added merge-early

change registerAutomaticDetection function structure

84af07eb

delete redundant brace(set)

2d88d8da

add type hint

e09c5d17

resolve feedback

3346248f

change [import typing] to [from typing]

6877379d

make f-string

9e176197

specify exception

be24784f

add log in unmatched portType

4f28277f

rollback userGuide

76b5f969

EdKweon marked this pull request as ready for review 1 year ago

seanbudd added this to the 2024.3 milestone 1 year ago

Update source/bdDetect.py

8079058b

Apply suggestions from code review

aca155cb

seanbudd commented on 2024-06-19

seanbudd marked this pull request as draft 1 year ago

Update source/brailleDisplayDrivers/hims.py

92bbd9b4

Update source/brailleDisplayDrivers/hims.py

c8134e5d

change variable name

04ce4c81

add comment

dbff32f4

add docstring FallbackDevicesStore class

55ab288c

modify docstring of FallbackDevicesStore

5ac7305c

EdKweon marked this pull request as ready for review 1 year ago

coderabbitai commented on 2024-06-19

seanbudd marked this pull request as draft 1 year ago

remove redundant brace

9dc15a16

simplify the return statement

f1aa7bb0

change fallbackDevices to module variable

3dd5f70b

EdKweon marked this pull request as ready for review 1 year ago

seanbudd approved these changes on 2024-06-26

fixups

11c5dbc3

seanbudd merged 76fe86ec into master 1 year ago

EdKweon deleted the FIX_HIMS_BRAILLE_OPTION branch 1 year ago

Reviewers

seanbudd

LeonarddeR

coderabbitai

lukaszgo1

michaelDCurran

Assignees

No one assigned

Labels

conceptApproved merge-early

Milestone

2024.3

nvda Add com port option in Braille Display Select Dialog and fix Serial Connection error #16340 Merged

Add com port option in Braille Display Select Dialog and fix Serial Connection error #16340

nvda
Add com port option in Braille Display Select Dialog and fix Serial Connection error
#16340

Merged