nvda
Give ui.browseableMessage the ability to show copy and close buttons after the message, and add buttons to some instances
#16369
Merged

Give ui.browseableMessage the ability to show copy and close buttons after the message, and add buttons to some instances #16369

seanbudd merged 45 commits into nvaccess:master from fix14641
XLTechie
AppVeyorBot
XLTechie XLTechie changed the title Add close, and close & copy buttons to some browseableMessages Give ui.browseableMessage the ability to show copy and close buttons after the message, and add buttons to two instances 2 years ago
XLTechie XLTechie changed the title Give ui.browseableMessage the ability to show copy and close buttons after the message, and add buttons to two instances Give ui.browseableMessage the ability to show copy and/or close buttons after the message, and add buttons to two instances 2 years ago
XLTechie
wmhn1872265132
CyrilleB79
XLTechie
XLTechie
CyrilleB79
XLTechie
Adriani90
XLTechie
Adriani90
XLTechie
seanbudd seanbudd added conceptApproved
seanbudd
XLTechie
Basic code in browseableMessage
e06d6133
Message.html changes to support optional close and copy buttons.
2dcd7f8c
Report link destination & character formatting browseableMessages giv…
d36f4801
Changes
2d3d6560
seanbudd seanbudd marked this pull request as ready for review 1 year ago
seanbudd seanbudd requested a review 1 year ago
seanbudd seanbudd requested a review from gerald-hartig gerald-hartig 1 year ago
coderabbitai
coderabbitai
coderabbitai commented on 2024-06-19
seanbudd seanbudd added blocked/needs-product-decision
Qchristensen
Removed customizable text for close button feature.
5bce4276
Added copy and close buttons to the Speak selection command browseabl…
2187b9e4
Added a close button to the Review current symbol command browseableM…
5c640e2c
Added alt+c keypress for the copy button.
1cb3e84c
AppVeyorBot
Revised changes.
a49e516f
AppVeyorBot
Fix indent error
934fab33
User alerts for copying (unlocalized).
c7499360
Add user alerts about completion, reorganize message.html code a bit.
e48229ad
seanbudd
seanbudd requested changes on 2024-06-25
seanbudd seanbudd removed blocked/needs-product-decision
seanbudd seanbudd marked this pull request as draft 1 year ago
XLTechie Apply suggestions from code review
56a16bef
XLTechie
XLTechie commented on 2024-06-26
XLTechie Adding missing translatable strings for copy operation alerts.
80d43572
XLTechie
XLTechie XLTechie changed the title Give ui.browseableMessage the ability to show copy and/or close buttons after the message, and add buttons to two instances Give ui.browseableMessage the ability to show copy and close buttons after the message, and add buttons to some instances 1 year ago
Merge tag 'prenormal' into fix14641
ef23a09e
Merge tag 'normalize' into fix14641
8b03cd23
renormalize files
eed604fb
Merge branch 'master' into fix14641
2253a8aa
Merge branch 'master' into fix14641
b6227e90
AppVeyorBot
Merge branch 'master' into fix14641
0ebe4968
pre-commit-ci[bot] Pre-commit auto-fix
fb880f5b
New alert code, using a live region.
6ee880cd
Remove failed attempt at Alt+C for Copy button press.
99263477
Move changes to correct version.
a6b8d78b
coderabbitai
coderabbitai commented on 2024-08-03
XLTechie
XLTechie commented on 2024-08-03
Added a new browsable message component failure messenging function.
f50d3974
f
14ea6de9
Used AI's proposed error handling in ui.py, with generic error messag…
cd71aaa2
pre-commit-ci[bot] Pre-commit auto-fix
43713e8d
XLTechie
Change onkeypress to onkeydown, in order to pick up Alt+C for copy.
cac67d78
XLTechie
britechguy
XLTechie
seanbudd
Implement a translatable accessibility label for the copy accelerator…
455769b8
Merge branch 'master' into fix14641
7f72d913
XLTechie
XLTechie
Solve for MSHTML bug in the use of aria-labelledby.
196e409e
XLTechie XLTechie marked this pull request as ready for review 1 year ago
Removed unnecessary comment
f8e3d86a
LeonarddeR
XLTechie
XLTechie
XLTechie
seanbudd
Merge branch 'master' into fix14641
3eb6ce31
XLTechie
AppVeyorBot
XLTechie XLTechie closed this 1 year ago
XLTechie XLTechie reopened this 1 year ago
XLTechie
seanbudd
seanbudd commented on 2024-08-08
seanbudd
seanbudd seanbudd marked this pull request as draft 1 year ago
XLTechie Update source/message.html to remove invalid language attribute
6aa5de0c
Merge branch 'master' into fix14641
82f1bb25
Add further explanation to the translation comment for the Alt+C copy…
bca9eeb0
Guard against code injection in copy status translations.
b1e220b4
Switch to innerText from innerHTML where possible.
5d107745
Slightly safer handling of messages.
a1336395
Close the Window if args wasn't provided.
268cc5f6
ID fix.
33378874
Merge branch 'master' into fix14641
cdbcdebd
Merge branch 'master' into fix14641
465f8520
XLTechie XLTechie marked this pull request as ready for review 1 year ago
XLTechie
seanbudd
XLTechie
seanbudd
seanbudd
seanbudd
seanbudd approved these changes on 2024-08-12
seanbudd Update source/message.html
2776962a
seanbudd seanbudd merged 2e09be1d into master 1 year ago
github-actions github-actions added this to the 2024.4 milestone 1 year ago
SaschaCowley
XLTechie

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone