nvda
Add-on Store: Added the action to cancel the install of a add-on when it is being downloaded.
#16671
Merged

Add-on Store: Added the action to cancel the install of a add-on when it is being downloaded. #16671

hwf1324
hwf1324 Add action to cancel download/install of add-on
aeb87cf7
hwf1324 Merge branch 'master' of https://github.com/nvaccess/nvda into cancel…
cf3a7942
hwf1324 hwf1324 requested a review 1 year ago
hwf1324 hwf1324 requested a review from SaschaCowley SaschaCowley 1 year ago
hwf1324
nvdaes
nvdaes commented on 2024-06-09
hwf1324
hwf1324 hwf1324 changed the title Add-on Store: Add the action to cancel the download/install of a add-on when it is being downloaded. Add-on Store: Added the action to cancel the download/install of a add-on when it is being downloaded. 1 year ago
nvdaes
cary-rowen
josephsl
josephsl commented on 2024-06-09
josephsl
cary-rowen
hwf1324 Add a description to the user guide and apply the recommendations of …
8d2b5107
hwf1324 hwf1324 requested a review 1 year ago
hwf1324 hwf1324 requested a review from Qchristensen Qchristensen 1 year ago
XLTechie
hwf1324
seanbudd seanbudd added conceptApproved
seanbudd
seanbudd seanbudd marked this pull request as draft 1 year ago
hwf1324 Merge branch 'master' of https://github.com/nvaccess/nvda into cancel…
46ae6f82
hwf1324 The actions are unified to cancel the install. Add a multi-select act…
cf0cc6be
hwf1324 hwf1324 changed the title Add-on Store: Added the action to cancel the download/install of a add-on when it is being downloaded. Add-on Store: Added the action to cancel the install of a add-on when it is being downloaded. 1 year ago
hwf1324 hwf1324 marked this pull request as ready for review 1 year ago
coderabbitai
AppVeyorBot
coderabbitai
coderabbitai commented on 2024-06-11
seanbudd
seanbudd requested changes on 2024-06-12
seanbudd seanbudd marked this pull request as draft 1 year ago
hwf1324 Apply review recommendations and split cancel download and install fu…
72c2c6af
hwf1324 hwf1324 requested a review from seanbudd seanbudd 1 year ago
hwf1324 Fix the condition error when calling to cancel download
a6f41d65
hwf1324 Improve the handling of download status changes.
d450fdfa
hwf1324 Merge branch 'master' of https://github.com/nvaccess/nvda into cancel…
93d71014
hwf1324 hwf1324 marked this pull request as ready for review 1 year ago
seanbudd
seanbudd commented on 2024-06-12
seanbudd
seanbudd commented on 2024-06-12
seanbudd seanbudd marked this pull request as draft 1 year ago
hwf1324 Organize code logic
5370ce4b
hwf1324 hwf1324 marked this pull request as ready for review 1 year ago
hwf1324
seanbudd
seanbudd
seanbudd commented on 2024-06-13
seanbudd
seanbudd commented on 2024-06-13
seanbudd seanbudd marked this pull request as draft 1 year ago
hwf1324 Applying the recommendations of the code review
e3acfba6
hwf1324 hwf1324 marked this pull request as ready for review 1 year ago
hwf1324
hwf1324 Improvement of judgment state logic
80be92c3
seanbudd
seanbudd seanbudd marked this pull request as draft 1 year ago
hwf1324 Merge branch 'master' of https://github.com/nvaccess/nvda into cancel…
ca4b2ad2
seanbudd seanbudd added merge-early
hwf1324
Adriani90
hwf1324 Merge commit '03364662e' into cancelDownloadOrInstallAddon
8c0014f7
hwf1324 Merge commit '8fb8ffcaba' into cancelDownloadOrInstallAddon
c636a770
hwf1324 renormalize files
b9f304fe
hwf1324 Merge remote-tracking branch 'origin/master' into cancelDownloadOrIns…
3fb57c9e
hwf1324 Merge branch 'master' of https://github.com/nvaccess/nvda into cancel…
a2a57448
seanbudd
hwf1324 Add code comment
88c211b8
hwf1324
hwf1324 Merge remote-tracking branch 'upstream/master' into cancelDownloadOrI…
cda4cd9c
seanbudd
hwf1324
hwf1324 Merge remote-tracking branch 'origin/master' into cancelDownloadOrIns…
92738d0a
AppVeyorBot
hwf1324 fix lint check
09eb826e
hwf1324 Merge branch 'master' of https://github.com/nvaccess/nvda into cancel…
a2bb9d0b
hwf1324 Merge remote-tracking branch 'upstream/master' into cancelDownloadOrI…
af42fe76
AppVeyorBot
hwf1324 Merge branch 'master' of https://github.com/hwf1324/nvda into cancelD…
8af46d33
seanbudd
hwf1324 Merge branch 'master' into cancelDownloadOrInstallAddon
c3869639
hwf1324 Merge branch 'master' of https://github.com/nvaccess/nvda into cancel…
868f1276
hwf1324 Clean temp download files
8070ff7a
hwf1324 Merge branch 'master' of https://github.com/nvaccess/nvda into cancel…
e41c8629
hwf1324 Fix location of delete temp files
700bfdd8
hwf1324 hwf1324 marked this pull request as ready for review 1 year ago
hwf1324
seanbudd
hwf1324
seanbudd
seanbudd commented on 2024-07-03
seanbudd seanbudd requested a review from seanbudd seanbudd 1 year ago
hwf1324 Apply review suggestions
adbb8756
hwf1324 Remove changes to network.py
abb0933b
seanbudd
seanbudd approved these changes on 2024-08-30
hwf1324
hwf1324 Elegant completion of the cancel install add-on
b336ccf0
hwf1324 Handle exceptions and add logs
8f68f94f
hwf1324
hwf1324 hwf1324 requested a review from seanbudd seanbudd 1 year ago
seanbudd
seanbudd commented on 2024-09-02
seanbudd
seanbudd commented on 2024-09-02
seanbudd
hwf1324
seanbudd Merge remote-tracking branch 'origin/master' into cancelDownloadOrIns…
8d4ceabe
seanbudd Add locks/threading
45f327e1
seanbudd
seanbudd seanbudd marked this pull request as draft 1 year ago
hwf1324 Merge pull request #1 from nvaccess/try-cancelDowndloadOrInstallAddon
7f4340de
hwf1324 If the Future is canceled early, the log will not report an error.
e628b69b
hwf1324 Fix incorrectly displaying the downloading dialogue box when exiting …
abeb28cd
hwf1324
seanbudd
seanbudd commented on 2024-09-02
seanbudd
seanbudd commented on 2024-09-02
hwf1324 Applying suggestions from code reviews
b07cb067
seanbudd
seanbudd commented on 2024-09-02
hwf1324 Applying suggestions from code reviews
1cf531e4
hwf1324 hwf1324 marked this pull request as ready for review 1 year ago
seanbudd
seanbudd commented on 2024-09-02
seanbudd Update source/addonStore/models/addon.py
4a67b0a7
seanbudd
seanbudd approved these changes on 2024-09-02
SaschaCowley
SaschaCowley requested changes on 2024-09-03
seanbudd add more comments and lock usage
7c44238e
seanbudd seanbudd force pushed from 7ff11f7e to 7c44238e 1 year ago
seanbudd seanbudd requested a review from SaschaCowley SaschaCowley 1 year ago
Qchristensen
Qchristensen approved these changes on 2024-09-06
SaschaCowley
SaschaCowley approved these changes on 2024-09-06
seanbudd Merge branch 'master' into cancelDownloadOrInstallAddon
c25d2cb8
seanbudd seanbudd merged 8cdd43a5 into master 1 year ago
github-actions github-actions added this to the 2025.1 milestone 1 year ago
hwf1324 hwf1324 deleted the cancelDownloadOrInstallAddon branch 1 year ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone